[GitHub] [spark] BryanCutler commented on a change in pull request #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)

[GitBox <gi...@apache.org>]

BryanCutler commented on a change in pull request #24734: [SPARK-27870][SQL][PySpark] Flush each batch for pandas UDF (for improving pandas UDFs pipeline)
URL: https://github.com/apache/spark/pull/24734#discussion_r288751402
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowPythonRunner.scala
 ##########
 @@ -87,6 +87,7 @@ class ArrowPythonRunner(
 
             arrowWriter.finish()
             writer.writeBatch()
+            dataOut.flush()
 
 Review comment:
   This block of code will write to `dataOut` until it is blocked because the write buffer is full. I think adding a `flush` here will only hurt performance

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org