You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/12/03 18:27:44 UTC

Re: Review Request 71814: Added support for new 'http+unix' URL scheme in libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71814/
-----------------------------------------------------------

(Updated Dec. 3, 2019, 6:27 p.m.)


Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Changes
-------

Some cleanup; experimentally removing windows ifdefs.


Summary (updated)
-----------------

Added support for new 'http+unix' URL scheme in libprocess.


Bugs: MESOS-10039
    https://issues.apache.org/jira/browse/MESOS-10039


Repository: mesos


Description
-------

Added support for a new 'http+unix' URL scheme, to denote
resources accessible by HTTP connections over unix domain
sockets.

The encoding looks like

    http+unix://<url-encoded filesystem path>/<http path>

optionally followed by query and fragment sections.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp 0013850f07110d9b9dbdb9b0c8ac7001a82420d2 
  3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399 


Diff: https://reviews.apache.org/r/71814/diff/2/

Changes: https://reviews.apache.org/r/71814/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 71814: Added support for new 'http+unix' URL scheme in libprocess.

Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71814/#review219208
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Dec. 3, 2019, 7:27 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71814/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2019, 7:27 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10039
>     https://issues.apache.org/jira/browse/MESOS-10039
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added support for a new 'http+unix' URL scheme, to denote
> resources accessible by HTTP connections over unix domain
> sockets.
> 
> The encoding looks like
> 
>     http+unix://<url-encoded filesystem path>/<http path>
> 
> optionally followed by query and fragment sections.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 0013850f07110d9b9dbdb9b0c8ac7001a82420d2 
>   3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399 
> 
> 
> Diff: https://reviews.apache.org/r/71814/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>