Re: [PR] Check administrator only when security is enabled [kyuubi]

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #5568:
URL: https://github.com/apache/kyuubi/pull/5568#discussion_r1378874243


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala:
##########
@@ -70,6 +71,17 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
 
   private lazy val port: Int = conf.get(FRONTEND_REST_BIND_PORT)
 
+  private lazy val isSecurityEnabled = {
+    val authTypes = conf.get(AUTHENTICATION_METHOD).map(AuthTypes.withName)
+    !authTypes.contains(NONE) && authTypes != Set(NOSASL)

Review Comment:
   FYI: I refactored code to reuse `getValidPasswordAuthMethod` as you suggested



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org