You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/04 00:33:39 UTC
[jira] [Commented] (KAFKA-3198) Ticket Renewal Thread exits
prematurely due to inverted comparison
[ https://issues.apache.org/jira/browse/KAFKA-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131378#comment-15131378 ]
ASF GitHub Bot commented on KAFKA-3198:
---------------------------------------
GitHub user kunickiaj opened a pull request:
https://github.com/apache/kafka/pull/858
KAFKA-3198: Ticket Renewal Thread exits prematurely due to inverted c…
KAFKA-3198: Ticket Renewal Thread exits prematurely due to inverted comparison
The >= should be < since we are actually able to renew if the renewTill time is later than the current ticket expiration.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunickiaj/kafka KAFKA-3198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/858.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #858
----
commit 65b10cd2e0bae97833be5459c29953695d8d396a
Author: Adam Kunicki <ad...@streamsets.com>
Date: 2016-02-03T18:35:29Z
KAFKA-3198: Ticket Renewal Thread exits prematurely due to inverted comparison
----
> Ticket Renewal Thread exits prematurely due to inverted comparison
> ------------------------------------------------------------------
>
> Key: KAFKA-3198
> URL: https://issues.apache.org/jira/browse/KAFKA-3198
> Project: Kafka
> Issue Type: Bug
> Components: security
> Affects Versions: 0.9.0.0
> Reporter: Adam Kunicki
> Assignee: Adam Kunicki
> Priority: Critical
>
> Line 152 of Login.java:
> {code}
> if (isUsingTicketCache && tgt.getRenewTill() != null && tgt.getRenewTill().getTime() >= expiry) {
> {code}
> This line is used to determine whether to exit the thread and issue an error to the user.
> The >= should be < since we are actually able to renew if the renewTill time is later than the current ticket expiration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)