You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by bhavya411 <gi...@git.apache.org> on 2017/11/09 09:21:56 UTC
[GitHub] carbondata pull request #1477: [CARBONDATA-1686] Presto Version Upgrade to 0...
GitHub user bhavya411 opened a pull request:
https://github.com/apache/carbondata/pull/1477
[CARBONDATA-1686] Presto Version Upgrade to 0.186
- [No] Any interfaces changed?
- [Yes ] Any backward compatibility impacted? Carbondata will now work with Presto Server 0.186 onward
- [ No] Document update required?
- [ Yes] Testing done
Since it is a version upgrade all the integration test cases are executed successfuly.
Performance testing done manually and there is improvement in query execution times.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bhavya411/incubator-carbondata PrestoUpgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1477.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1477
----
commit d2c8a479f0491b35b13ad6cf79595188ac609deb
Author: Bhavya <bh...@knoldus.com>
Date: 2017-11-09T07:25:50Z
Presto Version upgraded to 0.186
----
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1477
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1580/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1477
retest this please
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1477
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/943/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1477
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1543/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1477
retest this please
---
[GitHub] carbondata pull request #1477: [CARBONDATA-1686] Presto Version Upgrade to 0...
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1477#discussion_r149945794
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java ---
@@ -261,8 +261,6 @@ else if (type instanceof DecimalType) {
return new BigDecimal(new BigInteger(String.valueOf(rawdata)),
((DecimalType) type).getScale());
}
- } else if (type.equals(TimestampType.TIMESTAMP)) {
--- End diff --
This has been fixed
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1477
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1571/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1477
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1551/
---
[GitHub] carbondata pull request #1477: [CARBONDATA-1686] Presto Version Upgrade to 0...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1477
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1477
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/964/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1477
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1532/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1477
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/956/
---
[GitHub] carbondata pull request #1477: [CARBONDATA-1686] Presto Version Upgrade to 0...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1477#discussion_r149939306
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java ---
@@ -261,8 +261,6 @@ else if (type instanceof DecimalType) {
return new BigDecimal(new BigInteger(String.valueOf(rawdata)),
((DecimalType) type).getScale());
}
- } else if (type.equals(TimestampType.TIMESTAMP)) {
--- End diff --
this is PR1459 fixed TIMESTAMP issues.
---
[GitHub] carbondata pull request #1477: [CARBONDATA-1686] Presto Version Upgrade to 0...
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1477#discussion_r149944113
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java ---
@@ -78,10 +78,6 @@ private CarbondataPageSource(List<Type> types, RecordCursor cursor) {
this.readers = createStreamReaders();
}
- @Override public long getTotalBytes() {
--- End diff --
The Presto 0.186 has remove this method from specification, so we have to remove it from our code as well
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by bhavya411 <gi...@git.apache.org>.
Github user bhavya411 commented on the issue:
https://github.com/apache/carbondata/pull/1477
All issues have been resolved
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1477
@bhavya411 please rework this PR, there are many issues.
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1477
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/917/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1477
retest this please
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1477
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/928/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1477
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1558/
---
[GitHub] carbondata issue #1477: [CARBONDATA-1686] Presto Version Upgrade to 0.186
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1477
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/936/
---
[GitHub] carbondata pull request #1477: [CARBONDATA-1686] Presto Version Upgrade to 0...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1477#discussion_r149938802
--- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSource.java ---
@@ -78,10 +78,6 @@ private CarbondataPageSource(List<Type> types, RecordCursor cursor) {
this.readers = createStreamReaders();
}
- @Override public long getTotalBytes() {
--- End diff --
upgrade presto version , why need to remove this method ?
---