[GitHub] [arrow] adamreeve commented on a diff in pull request #35920: GH-18547: [Java] Support re-emitting dictionaries in ArrowStreamWriter

["adamreeve (via GitHub)" <gi...@apache.org>]

adamreeve commented on code in PR #35920:
URL: https://github.com/apache/arrow/pull/35920#discussion_r1218709202


##########
java/tools/src/main/java/org/apache/arrow/tools/EchoServer.java:
##########
@@ -135,6 +135,7 @@ public void run() throws IOException {
         Preconditions.checkState(reader.bytesRead() == writer.bytesWritten());
         LOGGER.debug(String.format("Echoed %d records", echoed));
         reader.close(false);
+        writer.close();

Review Comment:
   The `ArrowStreamWriter` not being closed meant that the copies of dictionary vectors it holds weren't being closed, so the allocator was throwing an `IllegalStateException` due to outstanding buffers. This is a behaviour change that users might need to watch out for.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org