You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/20 07:22:17 UTC

[GitHub] [tinkerpop] FlorianHockmann commented on a diff in pull request #1717: Match 3.5 changes in `gremlin-dotnet`

FlorianHockmann commented on code in PR #1717:
URL: https://github.com/apache/tinkerpop/pull/1717#discussion_r901332629


##########
gremlin-dotnet/src/pom.xml:
##########
@@ -65,14 +65,16 @@ limitations under the License.
                             </properties>
                             <scripts>
                                 <script>
-def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
-file.write(file.getText("UTF-8").replaceFirst(/&lt;Version&gt;(.*)&lt;\/Version&gt;/, "&lt;Version&gt;" + mavenVersion + "&lt;/Version&gt;"))
+                                    def mavenVersion = "${project.version}"

Review Comment:
   `mavenVersion` is already defined as a property above in line 62 here so I guess this shouldn't be needed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org