You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marcus Eriksson (Jira)" <ji...@apache.org> on 2019/10/18 12:23:00 UTC
[jira] [Comment Edited] (CASSANDRA-15365) Add primary key liveness
info when skipping illegal cells
[ https://issues.apache.org/jira/browse/CASSANDRA-15365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954547#comment-16954547 ]
Marcus Eriksson edited comment on CASSANDRA-15365 at 10/18/19 12:22 PM:
------------------------------------------------------------------------
[patch|https://github.com/krummas/cassandra/commits/marcuse/15365] which keeps track of whether the row only contains invalid cells, if so, we add the primary key liveness.
[circle|https://circleci.com/gh/krummas/workflows/cassandra/tree/marcuse%2F15365]
was (Author: krummas):
[patch|https://github.com/krummas/cassandra/commits/marcuse/15365] which keeps track of whether the row only contains invalid cells, if so, we add the primary key liveness.
> Add primary key liveness info when skipping illegal cells
> ---------------------------------------------------------
>
> Key: CASSANDRA-15365
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15365
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 3.0.x, 3.11.x
>
>
> In CASSANDRA-15086/CASSANDRA-15178 we started skipping the illegal legacy cells, problem is that if the row only contains illegal cells, we return a totally empty row which breaks stats collection: https://github.com/apache/cassandra/blob/93815db9853cb592edf13d82e91dc2e9d172f01f/src/java/org/apache/cassandra/db/rows/Rows.java#L70
> If the row only has these invalid cells, we should add a primary key liveness info to it to match the 2.1 behaviour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org