You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/26 08:14:54 UTC
[GitHub] [dubbo] plusmancn opened a new issue #8605: Does MetadataService really need the Activate filter chain? And there is not filter option to disable it.
plusmancn opened a new issue #8605:
URL: https://github.com/apache/dubbo/issues/8605
- [x] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
- [x] I have checked the [FAQ](https://github.com/apache/dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.
### Environment
* Dubbo version: xxx
* Operating System version: xxx
* Java version: xxx
### Steps to reproduce this issue
1. xxx
2. xxx
3. xxx
Pls. provide [GitHub address] to reproduce this issue.
### Expected Result
What do you expected from the above steps？
### Actual Result
What actually happens?
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn edited a comment on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn edited a comment on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909799606
@EarthChen
> In fact, these problems will not be encountered
It's common that users add `@Activate` to their self-defined filter, such as sentinel.
> all internal services cannot be initialized in the bootstrap
As far as I know, internal services like `Metaservice` are just normal services that can be described by `ServiceConfig`.
If you are sticking to separating it from `ServiceConfig`, maybe @AlbumenJ @chickenlj can answer your question and make a decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909238097
I think solution 2 is better and could even be considered entirely as an Internal service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-912359662
Related to #8666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen edited a comment on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen edited a comment on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909377868
> Yep, we need something like a whitelist or annotation to identify which services are internal services.
>
> But I'm not sure whether the multi-instances feature will break some conventions, so just wait for the 3.0.3 release.
I think we can consider implementing an internal service creation process instead of creating from serviceconfig. This is because I do not have this class at the rpc layer.
use proxy gen invoker and put it in the service repository is not good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn edited a comment on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn edited a comment on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909373097
Yep, we need something like a whitelist or annotation to identify which services are internal services.
But I'm not sure whether the multi-instances feature will break some conventions or not, so just wait for the 3.0.3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909238097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909354222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909354222
I will submit a PR after Dubbo 3.0.3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909377868
> Yep, we need something like a whitelist or annotation to identify which services are internal services.
>
> But I'm not sure whether the multi-instances feature will break some conventions, so just wait for the 3.0.3 release.
I think we can consider implementing an internal service creation process instead of creating from serviceconfig. This is because I do not have this class at the rpc layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen edited a comment on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen edited a comment on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909377868
> Yep, we need something like a whitelist or annotation to identify which services are internal services.
>
> But I'm not sure whether the multi-instances feature will break some conventions, so just wait for the 3.0.3 release.
I think we can consider implementing an internal service creation process instead of creating from serviceconfig. This is because I do not have this class at the rpc layer.
use proxy gen invoker and put it in the service repository is not good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909373097
Yep, we need something like a whitelist or annotation to identify which services are internal services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909783875
> implementing an internal service creation process instead of creating from serviceconfig
What's the benefit against the cost? The original purpose was only to guarantee the safety of internal service, and moreover `ProtocolFilterWrapper` have already implemented some feature which is similar to whitelist.
```java
// => org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper
@Override
public <T> Exporter<T> export(Invoker<T> invoker) throws RpcException {
// => Here, DON'T wrap with filter chain
if (UrlUtils.isRegistry(invoker.getUrl())) {
return protocol.export(invoker);
}
return protocol.export(builder.buildInvokerChain(invoker, SERVICE_FILTER_KEY, CommonConstants.PROVIDER));
}
@Override
public <T> Invoker<T> refer(Class<T> type, URL url) throws RpcException {
if (UrlUtils.isRegistry(url)) {
return protocol.refer(type, url);
}
return builder.buildInvokerChain(protocol.refer(type, url), REFERENCE_FILTER_KEY, CommonConstants.CONSUMER);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909798335
> > implementing an internal service creation process instead of creating from serviceconfig
>
> What's the benefit against the cost? The original purpose was only to guarantee the safety of internal service, and moreover `ProtocolFilterWrapper` have already implemented some feature which is similar to whitelist.
>
> ```java
> // => org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper
>
> @Override
> public <T> Exporter<T> export(Invoker<T> invoker) throws RpcException {
> // => Here, DON'T wrap with filter chain
> if (UrlUtils.isRegistry(invoker.getUrl())) {
> return protocol.export(invoker);
> }
> return protocol.export(builder.buildInvokerChain(invoker, SERVICE_FILTER_KEY, CommonConstants.PROVIDER));
> }
>
> @Override
> public <T> Invoker<T> refer(Class<T> type, URL url) throws RpcException {
> if (UrlUtils.isRegistry(url)) {
> return protocol.refer(type, url);
> }
> return builder.buildInvokerChain(protocol.refer(type, url), REFERENCE_FILTER_KEY, CommonConstants.CONSUMER);
> }
> ```
You're right about this. I agree to do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909362588
> I will submit a PR after Dubbo 3.0.3 release.
We're doing something similar in the tri protocol. Add some internal services, such as health checks, reflections, etc., and now it's the practice to use proxy to generate invoker, put it in the service repository, and put it in the pathresolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn removed a comment on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn removed a comment on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-912359662
Related to #8666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909799606
@EarthChen
> In fact, these problems will not be encountered
It's common that users add `@Activate` to their self-defined filter, such as sentinel.
> all internal services cannot be initialized in the bootstrap
As far as I know, internal services like `Metaservice` are just normal services that can be described by `ServiceConfig`.
If you are sticking to separate it from `ServiceConfig`, maybe @AlbumenJ @chickenlj can answer your question and make a decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn edited a comment on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn edited a comment on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909373097
Yep, we need something like a whitelist or annotation to identify which services are internal services.
But I'm not sure whether the multi-instances feature will break some conventions, so just wait for the 3.0.3 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909792260
This is another problem. In fact, I put forward this idea because of the consideration of the internal services of the current protocol, there are no things in the serviceconfig of the RPC layer, and the implementation is not elegant. Metaservice is currently initialized in the bootstrap. In fact, these problems will not be encountered, but all internal services cannot be initialized in the bootstrap, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
EarthChen commented on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909238097
I think solution 2 is better and could even be considered entirely as an Internal service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn edited a comment on issue #8605: Does MetadataService really need the external Activate filter chain? And there is no filter option to disable it.
Posted by GitBox <gi...@apache.org>.
plusmancn edited a comment on issue #8605:
URL: https://github.com/apache/dubbo/issues/8605#issuecomment-909373097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org