[GitHub] [skywalking] wu-sheng commented on a change in pull request #5972: Update backend-fetcher.md

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5972:
URL: https://github.com/apache/skywalking/pull/5972#discussion_r538116848



##########
File path: docs/en/setup/backend/backend-fetcher.md
##########
@@ -3,11 +3,14 @@ Fetcher is a concept in SkyWalking backend. It uses pulling mode rather than [re
 read the data from the target systems. This mode is typically in some metrics SDKs, such as Prometheus.
 
 ## Prometheus Fetcher
+Suppose you want to enable `metric-custom.yaml` stored at `fetcher-prom-rules`, append its name to `enabledRules` of 
+ `promethues-fetcher` as below:
+ 
 ```yaml
 prometheus-fetcher:
-  selector: ${SW_PROMETHEUS_FETCHER:default}
+  selector: ${SW_PROMETHEUS_FETCHER:-}

Review comment:
       ```suggestion
     selector: ${SW_PROMETHEUS_FETCHER:default}
   ```
   I think should be like this?

##########
File path: docs/en/setup/backend/backend-fetcher.md
##########
@@ -3,11 +3,14 @@ Fetcher is a concept in SkyWalking backend. It uses pulling mode rather than [re
 read the data from the target systems. This mode is typically in some metrics SDKs, such as Prometheus.
 
 ## Prometheus Fetcher
+Suppose you want to enable `metric-custom.yaml` stored at `fetcher-prom-rules`, append its name to `enabledRules` of 

Review comment:
       ```suggestion
   Suppose you want to enable some `metric-custom.yaml` files stored at `fetcher-prom-rules`, append its name to `enabledRules` of 
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org