[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#discussion_r714628413



##########
File path: test/integration/smoke/test_snapshots.py
##########
@@ -245,23 +245,30 @@ def test_02_list_snapshots_with_removed_data_store(self):
             PASS,
             "Invalid response returned for list volumes")
         vol_uuid = vol_res[0].id
-        
-        # Create new Primary Storage
         clusters = list_clusters(
             self.apiclient,
             zoneid=self.zone.id
         )
         assert isinstance(clusters,list) and len(clusters)>0
 
+        self.cleanup.append(self.virtual_machine_with_disk)

Review comment:
       this is not created here. I applaud the move , but should't it be registered for cleanup right after creation to prevent it being left if an exception occurs in the meanwhile?
   also as it is created at class level it should go in `_cleanup` and not in `cleanup`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org