[GitHub] [incubator-mxnet] access2rohit edited a comment on pull request #19381: numpy tril_indices large tensor fix

[GitBox <gi...@apache.org>]

access2rohit edited a comment on pull request #19381:
URL: https://github.com/apache/incubator-mxnet/pull/19381#issuecomment-716881145


   ```
   tril_indices(n, k=0, m=None)
       Return the indices for the lower-triangle of an (n, m) array.
       Parameters
       ----------
       n : int
           The row dimension of the arrays for which the returned
           indices will be valid.
       k : int, optional
           Diagonal offset (see `tril` for details).
       m : int, optional
           .. versionadded:: 1.9.0
   
           The column dimension of the arrays for which the returned
           arrays will be valid.
           By default `m` is taken equal to `n`.
   ```
   Don't you think params `n` and `m` should be of type `index_t` either could be >= 2^31 ?
   also since `k` is offset this needs to be `index_t` as well


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org