You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/05/28 03:45:26 UTC

[GitHub] [incubator-druid] clintropolis commented on issue #7770: Web console: Adding a server view that can display all servers

clintropolis commented on issue #7770: Web console: Adding a server view that can display all servers
URL: https://github.com/apache/incubator-druid/pull/7770#issuecomment-496354597
 
 
   travis failure looks legitimate https://travis-ci.org/apache/incubator-druid/jobs/537985537#L1726
   
   ```
   [INFO] FAIL src/components/sql-control/sql-control.spec.tsx
   [INFO]   ● Test suite failed to run
   [INFO] 
   [INFO]     TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
   [INFO]     src/components/sql-control/sql-control.spec.tsx:30:9 - error TS2322: Type '(query: string, bypassCache: boolean, wrapQuery: boolean) => void' is not assignable to type '(query: string, context: Record<string, any>, wrapQuery: boolean) => void'.
   [INFO]       Types of parameters 'bypassCache' and 'context' are incompatible.
   [INFO]         Type 'Record<string, any>' is not assignable to type 'boolean'.
   [INFO] 
   [INFO]     30         onRun={(query: string, bypassCache: boolean, wrapQuery: boolean) => {}}
   [INFO]                ~~~~~
   [INFO] 
   [INFO]       src/components/sql-control/sql-control.tsx:61:3
   [INFO]         61   onRun: (query: string, context: Record<string, any>, wrapQuery: boolean) => void;
   [INFO]              ~~~~~
   [INFO]         The expected type comes from property 'onRun' which is declared here on type 'IntrinsicAttributes & IntrinsicClassAttributes<SqlControl> & Readonly<SqlControlProps> & Readonly<{ children?: ReactNode; }>'
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org