You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2025/03/06 16:42:04 UTC
[PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
andygrove opened a new pull request, #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
N/A
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
To prevent regressions and track progress with supporting `native_datafusion`, I would like to start enabling CI runs with this scan as the default.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- [x] Enable CI check with `native_datafusion` enabled
- [ ] Skip currently failing tests using `assume(!CometConf.nativeDataFusionParquetExec)`
- [ ] File tracking issue to fix the skipped tests
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#issuecomment-2704535303
## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1479?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 58.10%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`94cfd50`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/94cfd50a4e6ca5090ecfe75ba82f08e775b61f0c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 63 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1479 +/- ##
============================================
+ Coverage 56.12% 58.10% +1.98%
- Complexity 976 1008 +32
============================================
Files 119 122 +3
Lines 11743 12203 +460
Branches 2251 2303 +52
============================================
+ Hits 6591 7091 +500
+ Misses 4012 3924 -88
- Partials 1140 1188 +48
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1479?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>🚀 New features to boost your workflow: </summary>
- ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1984269973
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -900,9 +900,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}
test("cast TimestampType to LongType") {
- assume(
- !CometConf.isExperimentalNativeScan
- ) // https://github.com/apache/datafusion-comet/issues/1441
+ // https://github.com/apache/datafusion-comet/issues/1441assume(!CometConf.isExperimentalNativeScan)
Review Comment:
`assume(!CometConf.isExperimentalNativeScan)` got appended to the end of the issue link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1984280230
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +76,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ linux-test-native-datafusion-scan:
+ env:
+ COMET_PARQUET_SCAN_IMPL: "native_datafusion"
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [17]
+ test-target: [rust, java]
+ spark-version: ['3.5']
+ scala-version: ['2.12']
Review Comment:
I was thinking that this would be enough for now to prevent regressions while this is still an experimental feature.
We could increase the matrix here but it will add overhead to all PRs. What do you think @mbutrovich?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1985845051
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +76,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ linux-test-native-datafusion-scan:
+ env:
+ COMET_PARQUET_SCAN_IMPL: "native_datafusion"
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [17]
+ test-target: [rust, java]
+ spark-version: ['3.5']
+ scala-version: ['2.12']
Review Comment:
Sure, would you mind filing an issue to track this? I will go ahead and approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1985499353
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +76,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ linux-test-native-datafusion-scan:
+ env:
+ COMET_PARQUET_SCAN_IMPL: "native_datafusion"
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [17]
+ test-target: [rust, java]
+ spark-version: ['3.5']
+ scala-version: ['2.12']
Review Comment:
@kazuyukitanimura Could we merge this PR to add these initial checks. We currently have almost zero tests running in CI for `native_datafusion`, so this is a big step forward. It is just the first step though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1985846108
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +76,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ linux-test-native-datafusion-scan:
+ env:
+ COMET_PARQUET_SCAN_IMPL: "native_datafusion"
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [17]
+ test-target: [rust, java]
+ spark-version: ['3.5']
+ scala-version: ['2.12']
Review Comment:
Thanks. I filed https://github.com/apache/datafusion-comet/issues/1486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1985101911
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +76,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ linux-test-native-datafusion-scan:
+ env:
+ COMET_PARQUET_SCAN_IMPL: "native_datafusion"
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [17]
+ test-target: [rust, java]
+ spark-version: ['3.5']
+ scala-version: ['2.12']
Review Comment:
I have not tested Spark 3.5, Spark 4.0, Scala 2.13 with `native_datafusion` and would prefer not to get spread too thin if we get a deluge of issues. I propose walking before we run and get this pipeline in great shape and then add more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1984276262
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -900,9 +900,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}
test("cast TimestampType to LongType") {
- assume(
- !CometConf.isExperimentalNativeScan
- ) // https://github.com/apache/datafusion-comet/issues/1441
+ // https://github.com/apache/datafusion-comet/issues/1441assume(!CometConf.isExperimentalNativeScan)
Review Comment:
This was fixed already in https://github.com/apache/datafusion-comet/pull/1479/commits/61a307148fedf643b39acd27af5fe560fd5a65e6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#issuecomment-2705321383
> I think we will need spark sql tests as well
Eventually, yes. I don't think we can support that yet, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#issuecomment-2704672123
@mbutrovich could you review when you have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1984245699
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +76,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ linux-test-native-datafusion-scan:
+ env:
+ COMET_PARQUET_SCAN_IMPL: "native_datafusion"
+ strategy:
+ matrix:
+ os: [ubuntu-latest]
+ java_version: [17]
+ test-target: [rust, java]
+ spark-version: ['3.5']
+ scala-version: ['2.12']
Review Comment:
What about other versions? Spark 3.4, 4.0, Scala 2.13?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1984220205
##########
.github/workflows/pr_build.yml:
##########
@@ -76,6 +76,41 @@ jobs:
# upload test reports only for java 17
upload-test-reports: ${{ matrix.java_version == '17' }}
+ linux-test-native-datafusion-scan:
+ env:
+ COMET_PARQUET_SCAN_IMPL: "native_datafusion"
Review Comment:
This job is a copy of the regular job but enabling this env var
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] chore: Enable CI checks for `native_datafusion` scan [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on code in PR #1479:
URL: https://github.com/apache/datafusion-comet/pull/1479#discussion_r1985097585
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -900,9 +900,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}
test("cast TimestampType to LongType") {
- assume(
- !CometConf.isExperimentalNativeScan
- ) // https://github.com/apache/datafusion-comet/issues/1441
+ // https://github.com/apache/datafusion-comet/issues/1441assume(!CometConf.isExperimentalNativeScan)
Review Comment:
Sorry about that--I must have followed a notification to an old commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org