[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

["Skye Wanderman-Milne (Code Review)" <ge...@cloudera.org>]

Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2113/1/be/src/exec/partitioned-hash-join-node-ir.cc
File be/src/exec/partitioned-hash-join-node-ir.cc:

Line 289: AddProbeFilters
> I just ran some local runs.
New numbers with a no-asserts LLVM build:

With template:
  PHJ time: 24.5s
  Build time: 5.4s
  Codegen time: 473ms

Trunk:
  PHJ time: 26.3s
  Build time: 8.7s
  Codegen time: 376ms

So codegen time is definitely better now, although this will regress 2.5.

Also, did I do something wrong or did we regress PHJ?


-- 
To view, visit http://gerrit.cloudera.org:8080/2113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I616f46a861b4909d7a6e66dcf947b3518556768e
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <sk...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes