[GitHub] [streampipes] bossenti commented on a diff in pull request #1147: refactor: further clean up python data model & introduce function definition

["bossenti (via GitHub)" <gi...@apache.org>]

bossenti commented on code in PR #1147:
URL: https://github.com/apache/streampipes/pull/1147#discussion_r1085242291


##########
streampipes-client-python/streampipes_client/model/common.py:
##########
@@ -55,30 +55,33 @@ class BaseElement(BasicModel):
     element_id: Optional[StrictStr]
 
 
-class EventPropertyQualityRequirement(BaseElement):
+class EventPropertyQualityRequirement(BasicModel):
     """
     Data model of an `EventPropertyQualityRequirement` in compliance to the StreamPipes Backend.
     """
 
+    element_id: Optional[StrictStr]
     minimum_property_quality: Optional[BaseElement] = Field(alias="eventPropertyQualityDefinition")
     maximum_property_quality: Optional[BaseElement] = Field(alias="eventPropertyQualityDefinition")

Review Comment:
   That would be great 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org