You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/15 13:12:45 UTC
[GitHub] [pulsar] Technoboy- opened a new pull request #14692: Support creating replicate subscription in CLI.
Technoboy- opened a new pull request #14692:
URL: https://github.com/apache/pulsar/pull/14692
Master Issue: #11366
### Motivation
Currently, `pulsar-admin topics create-subscription` doesn't support creating replicated subscriptions, but Rest API has already supported this.
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #14692: Support creating replicate subscription in CLI.
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #14692:
URL: https://github.com/apache/pulsar/pull/14692#discussion_r826964565
##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1595,7 +1596,52 @@ void expireMessagesForAllSubscriptions(String topic, long expireTimeInSeconds)
* @throws PulsarAdminException
* Unexpected error
*/
- void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ @Deprecated
Review comment:
We don't need to deprecate this one?
##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1595,7 +1596,52 @@ void expireMessagesForAllSubscriptions(String topic, long expireTimeInSeconds)
* @throws PulsarAdminException
* Unexpected error
*/
- void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ @Deprecated
+ default void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ throws PulsarAdminException {
+ createSubscription(topic, subscriptionName, messageId, false);
+ };
+
+ /**
+ * Use {@link Topics#createSubscriptionAsync(String, String, MessageId, boolean)} instead.
+ * Create a new subscription on a topic.
+ *
+ * @param topic
+ * topic name
+ * @param subscriptionName
+ * Subscription name
+ * @param messageId
+ * The {@link MessageId} on where to initialize the subscription. It could be {@link MessageId#latest},
+ * {@link MessageId#earliest} or a specific message id.
+ */
+ @Deprecated
Review comment:
Same as the above comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a change in pull request #14692: Support creating replicate subscription in CLI.
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #14692:
URL: https://github.com/apache/pulsar/pull/14692#discussion_r827048025
##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1595,7 +1596,52 @@ void expireMessagesForAllSubscriptions(String topic, long expireTimeInSeconds)
* @throws PulsarAdminException
* Unexpected error
*/
- void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ @Deprecated
Review comment:
fixed
##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1595,7 +1596,52 @@ void expireMessagesForAllSubscriptions(String topic, long expireTimeInSeconds)
* @throws PulsarAdminException
* Unexpected error
*/
- void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ @Deprecated
+ default void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ throws PulsarAdminException {
+ createSubscription(topic, subscriptionName, messageId, false);
+ };
+
+ /**
+ * Use {@link Topics#createSubscriptionAsync(String, String, MessageId, boolean)} instead.
+ * Create a new subscription on a topic.
+ *
+ * @param topic
+ * topic name
+ * @param subscriptionName
+ * Subscription name
+ * @param messageId
+ * The {@link MessageId} on where to initialize the subscription. It could be {@link MessageId#latest},
+ * {@link MessageId#earliest} or a specific message id.
+ */
+ @Deprecated
Review comment:
fix
##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1595,7 +1596,52 @@ void expireMessagesForAllSubscriptions(String topic, long expireTimeInSeconds)
* @throws PulsarAdminException
* Unexpected error
*/
- void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ @Deprecated
+ default void createSubscription(String topic, String subscriptionName, MessageId messageId)
+ throws PulsarAdminException {
+ createSubscription(topic, subscriptionName, messageId, false);
+ };
+
+ /**
+ * Use {@link Topics#createSubscriptionAsync(String, String, MessageId, boolean)} instead.
+ * Create a new subscription on a topic.
+ *
+ * @param topic
+ * topic name
+ * @param subscriptionName
+ * Subscription name
+ * @param messageId
+ * The {@link MessageId} on where to initialize the subscription. It could be {@link MessageId#latest},
+ * {@link MessageId#earliest} or a specific message id.
+ */
+ @Deprecated
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14692: Support creating replicate subscription in CLI.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14692:
URL: https://github.com/apache/pulsar/pull/14692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org