You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2017/05/24 09:07:04 UTC
[jira] [Commented] (SOLR-10738) TriggerAction is initialised even
if the trigger is never scheduled
[ https://issues.apache.org/jira/browse/SOLR-10738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022575#comment-16022575 ]
Shalin Shekhar Mangar commented on SOLR-10738:
----------------------------------------------
A side effect of this problem was that the actionCreated latch used in TriggerIntegrationTest wasn't useful at all and would fire much before the trigger is ready to be scheduled leading to spurious test failures. Thanks to [~ab] for catching this during his testing.
> TriggerAction is initialised even if the trigger is never scheduled
> -------------------------------------------------------------------
>
> Key: SOLR-10738
> URL: https://issues.apache.org/jira/browse/SOLR-10738
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: master (7.0)
>
> Attachments: SOLR-10738.patch
>
>
> The zk watcher responsible for creating triggers creates them blindly without checking if the trigger is actually modified. This is be design as ScheduledTriggers.add is a no-op if the trigger being added is unchanged. However, since the trigger's actions are initialised in the trigger's constructor, they are inited needlessly by the zk watcher thread even though we may never schedule those trigger instances (because they are unchanged). So I propose to change the TriggerAction lifecycle such that the TriggerAction.init is only called when the trigger is actually ready to be scheduled.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org