You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@freestoneinfotech.com> on 2016/05/13 04:08:22 UTC

Review Request 47330: RANGER-984 : Ranger Admin Install fails with message "022-split-service-table.sql Import failed!"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47330/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-984
    https://issues.apache.org/jira/browse/RANGER-984


Repository: ranger


Description
-------

**Problem Statement :**
Ranger install failing for Oracle DB flavor while applying SQL DB patch '022-split-service-table.sql'.
Currently SQL script 022-split-service-table.sql written for oracle is not according to Oracle SQL syntax.
For example : Below given SQL statement are not supported in Oracle DB.
* DROP SEQUENCE IF EXISTS x_service_version_info_seq;
* DROP TABLE IF EXISTS `x_service_version_info`;
**Proposed Solution :**
I am rewriting Oracle SQL script of patch '022-split-service-table.sql' according to Oracle DB Flavor.


Diffs
-----

  security-admin/db/mysql/patches/022-split-service-table.sql 962e715 
  security-admin/db/oracle/patches/022-split-service-table.sql 7059be2 

Diff: https://reviews.apache.org/r/47330/diff/


Testing
-------

**Steps Performed (with patch) :**
1. After Build untar the Ranger module and updated install.properties for oracle DB flavor.
2. Called setup.sh to install Ranger.

**Expected Behavior :**
1. Ranger installation should finish successfully and should not failed while applying SQL patch '022-split-service-table.sql'.
2. Ranger UI should work.

**Actual Behavior :**
1. Ranger Installtion finished successfully and failure of SQL patch '022-split-service-table.sql' was not observed.
2. Started Ranger Admin and was able to login in Ranger UI.

**Note:** patch '022-split-service-table.sql' of mysql version is also updated and sql script is aligned according to standard being followed in previous sql patches.


Thanks,

Pradeep Agrawal


Re: Review Request 47330: RANGER-984 : Ranger Admin Install fails with message "022-split-service-table.sql Import failed!"

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47330/#review133029
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 13, 2016, 4:08 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47330/
> -----------------------------------------------------------
> 
> (Updated May 13, 2016, 4:08 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-984
>     https://issues.apache.org/jira/browse/RANGER-984
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement :**
> Ranger install failing for Oracle DB flavor while applying SQL DB patch '022-split-service-table.sql'.
> Currently SQL script 022-split-service-table.sql written for oracle is not according to Oracle SQL syntax.
> For example : Below given SQL statement are not supported in Oracle DB.
> * DROP SEQUENCE IF EXISTS x_service_version_info_seq;
> * DROP TABLE IF EXISTS `x_service_version_info`;
> **Proposed Solution :**
> I am rewriting Oracle SQL script of patch '022-split-service-table.sql' according to Oracle DB Flavor.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/patches/022-split-service-table.sql 962e715 
>   security-admin/db/oracle/patches/022-split-service-table.sql 7059be2 
> 
> Diff: https://reviews.apache.org/r/47330/diff/
> 
> 
> Testing
> -------
> 
> **Steps Performed (with patch) :**
> 1. After Build untar the Ranger module and updated install.properties for oracle DB flavor.
> 2. Called setup.sh to install Ranger.
> 
> **Expected Behavior :**
> 1. Ranger installation should finish successfully and should not failed while applying SQL patch '022-split-service-table.sql'.
> 2. Ranger UI should work.
> 
> **Actual Behavior :**
> 1. Ranger Installtion finished successfully and failure of SQL patch '022-split-service-table.sql' was not observed.
> 2. Started Ranger Admin and was able to login in Ranger UI.
> 
> **Note:** patch '022-split-service-table.sql' of mysql version is also updated and sql script is aligned according to standard being followed in previous sql patches.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>