You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/17 21:50:40 UTC
[GitHub] [incubator-mxnet] apeforest edited a comment on issue #15169:
Softmax with length
apeforest edited a comment on issue #15169: Softmax with length
URL: https://github.com/apache/incubator-mxnet/pull/15169#issuecomment-512582221
This PR is more like patching an existing function to implement a feature which is not generally needed. From software engineering practice, this PR introduced unnecessary redundancy in the code and the performance impact is not well measured.
As we discussed offline, if this feature is urgently needed and the code has to be patched in such a way to maintain backward compatibility, it might be okay to ship as it is. However, we should add a TODO in MXNet 2.0 to rewrite softmax from scratch taking into consideration of all the required scenarios and how to make it extensible.
@szha for review and final approve.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services