[GitHub] [tvm] zxybazh commented on a diff in pull request #12628: [MetaSchedule] Introduce `Union` and `OrderedUnion` in Database

[GitBox <gi...@apache.org>]

zxybazh commented on code in PR #12628:
URL: https://github.com/apache/tvm/pull/12628#discussion_r959908816


##########
include/tvm/meta_schedule/database.h:
##########
@@ -357,6 +357,22 @@ class Database : public runtime::ObjectRef {
    */
   TVM_DLL static Database JSONDatabase(String path_workload, String path_tuning_record,
                                        bool allow_missing);
+  /*!
+   * \brief A database composed of multiple databases, allowing users to guide IR rewriting using
+   * combined knowledge of those databases. To each query, it returns the best record among all the
+   * databases given.
+   * \param databases The list of databases to be combined.
+   * \return The combined database.
+   */
+  TVM_DLL static Database UnionDatabase(Array<Database, void> databases);

Review Comment:
   I think given `Union Database` it's easy to think of a database which returns the best result among all databases given, and this is consistent with the database api of get top k. For `OrderedUnionDatabase` I agree the name is a bit not straghtforward, maybe it could be changed to something like `FirstAvailableUnionDatabase`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org