[GitHub] [hudi] danny0405 commented on a diff in pull request #6991: [HUDI-5049] HoodieCatalog supports the implementation of dropPartition

[GitBox <gi...@apache.org>]

danny0405 commented on code in PR #6991:
URL: https://github.com/apache/hudi/pull/6991#discussion_r1001593967


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieHiveCatalog.java:
##########
@@ -488,8 +495,9 @@ private void initTableIfNotExists(ObjectPath tablePath, CatalogTable catalogTabl
     }
   }
 
-  private String inferTablePath(ObjectPath tablePath, CatalogBaseTable table) {
-    String location = table.getOptions().getOrDefault(PATH.key(), "");
+  @VisibleForTesting
+  public String inferTablePath(ObjectPath tablePath, CatalogBaseTable table) {

Review Comment:
   Revert this change, the `table` should never be null and we should respect the path of the table options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org