You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jingi723 (via GitHub)" <gi...@apache.org> on 2026/09/29 04:50:05 UTC
[PR] Handle plain Step Functions execution errors [airflow]
jingi723 opened a new pull request, #73881:
URL: https://github.com/apache/airflow/pull/73881
`StepFunctionGetExecutionOutputOperator` raises `JSONDecodeError` when `DescribeExecution` returns an ordinary error such as `States.TaskFailed`. AWS documents [`error` as a string](https://docs.aws.amazon.com/step-functions/latest/apireference/API_DescribeExecution.html#API_DescribeExecution_ResponseSyntax), whereas `output` contains JSON data.
Return non-JSON errors unchanged, including empty strings. Preserve JSON-decoded error return values for compatibility and keep invalid success output and service exceptions visible. Document that fetching an error may complete the Airflow task successfully; checking remote execution success remains the responsibility of `StepFunctionExecutionSensor`. The documentation also explains the constraints on string results with `multiple_outputs` and dynamic task mapping.
Validation on Python 3.10 in the official Linux/amd64 Breeze CI image:
- Regression tests against the unchanged operator: 4 failed, 5 passed. With the fix, the related Step Functions operator, hook, sensor and trigger suite: 38 passed.
- Regression tests use a real boto3 client and hook with botocore `Stubber`; a separate local synthetic HTTP-response experiment also exercised the botocore response parser. Neither contacts AWS.
- Regular and manual prek checks passed, including provider mypy; commit-message checks and `git diff --check` passed.
- Selective-check completed. The wider dependent-provider, Airflow-version, documentation-build and system-test matrices were not run locally. Actual AWS executions and full task-runner/XCom integration were not tested.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — OpenAI Codex (GPT-6)
Generated-by: OpenAI Codex (GPT-6) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle plain Step Functions execution errors [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #73881:
URL: https://github.com/apache/airflow/pull/73881#issuecomment-5996010258
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle plain Step Functions execution errors [airflow]
Posted by "jingi723 (via GitHub)" <gi...@apache.org>.
jingi723 commented on code in PR #73881:
URL: https://github.com/apache/airflow/pull/73881#discussion_r4140423194
##########
providers/amazon/docs/changelog.rst:
##########
@@ -26,6 +26,12 @@
Changelog
---------
+.. note::
+ ``StepFunctionGetExecutionOutputOperator`` now returns non-JSON execution errors as strings
Review Comment:
Removed the changelog note in 99b27dc8.
---
Drafted-by: OpenAI Codex (GPT-6) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle plain Step Functions execution errors [airflow]
Posted by "jingi723 (via GitHub)" <gi...@apache.org>.
jingi723 commented on PR #73881:
URL: https://github.com/apache/airflow/pull/73881#issuecomment-5946624264
The requested changelog removal is addressed, and the related tests and local checks passed. Could a maintainer approve the pending CI runs and take another look when available? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle plain Step Functions execution errors [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #73881:
URL: https://github.com/apache/airflow/pull/73881#discussion_r4135457277
##########
providers/amazon/docs/changelog.rst:
##########
@@ -26,6 +26,12 @@
Changelog
---------
+.. note::
+ ``StepFunctionGetExecutionOutputOperator`` now returns non-JSON execution errors as strings
Review Comment:
I dont think this is worth mentioning in the changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle plain Step Functions execution errors [airflow]
Posted by "jingi723 (via GitHub)" <gi...@apache.org>.
jingi723 commented on code in PR #73881:
URL: https://github.com/apache/airflow/pull/73881#discussion_r4140423194
##########
providers/amazon/docs/changelog.rst:
##########
@@ -26,6 +26,12 @@
Changelog
---------
+.. note::
+ ``StepFunctionGetExecutionOutputOperator`` now returns non-JSON execution errors as strings
Review Comment:
Removed the changelog note in 99b27dc8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Handle plain Step Functions execution errors [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #73881:
URL: https://github.com/apache/airflow/pull/73881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org