You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/03/16 01:22:32 UTC

[GitHub] [pinot] walterddr commented on a diff in pull request #10432: [multistage] fix mailbox cancel race condition

walterddr commented on code in PR #10432:
URL: https://github.com/apache/pinot/pull/10432#discussion_r1137981097


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -72,6 +75,7 @@ public void send(TransferableBlock block)
   @Override
   public void complete()
       throws Exception {
+    // TODO: should wait for _mailboxContentStreamObserver.onNext() finish before calling onComplete().

Review Comment:
   currently it is guaranteed that onComplete is called after all onNext() --> implicitly via the OpChain scheduler



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org