You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jtjeferreira (via GitHub)" <gi...@apache.org> on 2023/12/27 14:56:31 UTC
[PR] Kinesis: fix maxBytesPerSecond throttling [incubator-pekko-connectors]
jtjeferreira opened a new pull request, #298:
URL: https://github.com/apache/incubator-pekko-connectors/pull/298
The kinesis throttling is not being respected because the function `getPayloadByteSize` is incorrect.
```scala
private def getPayloadByteSize[T](record: (PutRecordsRequestEntry, T)): Int = record match {
case (request, _) => request.partitionKey.length + request.data.asByteBuffer.position()
}
```
`request.data.asByteBuffer.position()` can return 0
The ticket was originally reported in https://github.com/akka/alpakka/issues/2871 and I did the fix in the akka repository. AFAICT I can use the same code as long as I am the author...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Kinesis: fix maxBytesPerSecond throttling [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #298:
URL: https://github.com/apache/incubator-pekko-connectors/pull/298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Kinesis: fix maxBytesPerSecond throttling [incubator-pekko-connectors]
Posted by "jtjeferreira (via GitHub)" <gi...@apache.org>.
jtjeferreira commented on PR #298:
URL: https://github.com/apache/incubator-pekko-connectors/pull/298#issuecomment-1871030533
> lgtm. If we wan't to be strict this should land in 1.1.0 since this is a behaviour change but afaict the current functionality appears to be broken so this can be an exception
>
> @jtjeferreira Can you confirm?
yes the current functionality is broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Kinesis: fix maxBytesPerSecond throttling [incubator-pekko-connectors]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #298:
URL: https://github.com/apache/incubator-pekko-connectors/pull/298#issuecomment-1871045928
Merging - as it is a bug fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org