[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3809: drivers/spi: Change prefix to a more intuitive "spislave"

[GitBox <gi...@apache.org>]

gustavonihei commented on a change in pull request #3809:
URL: https://github.com/apache/incubator-nuttx/pull/3809#discussion_r643397626



##########
File path: drivers/spi/spi_slave_driver.c
##########
@@ -57,7 +57,7 @@
  * Private Types
  ****************************************************************************/
 
-struct spislv_driver_s
+struct spislave_driver_s

Review comment:
       The `spislave_driver_s` follows the same pattern from the `spi_driver_s` naming, considering `spislave_` as the single prefix.
   
   I agree that `spi_sdev_` would be in sync with the prefix adopted in `slave.h`, but it is difficult to infer that `sdev` refers to Slave Device. The same with `spi_sctrlr`. On the other hand, `spislave_dev` and `spislave_ctrlr` are self explanatory, don't you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org