You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/03/08 03:26:57 UTC

[GitHub] [kyuubi] zwangsheng commented on a diff in pull request #4471: [Improve][Test] Notify user fix setting.md with mvn opt `-DskipTests` to skip unrelated unit test

zwangsheng commented on code in PR #4471:
URL: https://github.com/apache/kyuubi/pull/4471#discussion_r1128937701


##########
kyuubi-common/src/test/scala/org/apache/kyuubi/MarkdownUtils.scala:
##########
@@ -50,7 +50,7 @@ object MarkdownUtils {
         withClue(s"$markdown out of date, as line ${index + 1} is not expected." +
           " Please update doc with KYUUBI_UPDATE=1 build/mvn clean test" +
           s" -pl $module -am -Pflink-provided,spark-provided,hive-provided" +
-          s" -DwildcardSuites=$agent") {
+          s" -DwildcardSuites=$agent -DskipTests") {

Review Comment:
   Well, get this point.
   
   According to https://spark.apache.org/developer-tools.html#individual-tests, recommended use `-Dtest=none` to skip java test.
   
   Thanks for suggestion, i'll push a commit fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org