You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Niall Pemberton <ni...@gmail.com> on 2009/08/03 02:35:45 UTC

[VOTE] Release Codec 1.4 based on RC3

I have prepared a third release candidate for Codec 1.4 following the
feedback from the first.

[ ] +1 Yes go ahead an release based on RC3
[ ] -1 No, because...

The tag for RC3 is here:
http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/

The release artefacts are here
http://people.apache.org/~niallp/codec-1.4-rc3/

Site is available here:
http://people.apache.org/~niallp/codec-1.4-rc3/site/
(note: some links are relative and will be broken until deployed to
proper codec home)

RAT Report:
http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html

CLIRR Report:
http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html

Release Notes:
http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt

Thanks

Niall

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, Aug 3, 2009 at 9:33 AM, Gary
Gregory<GG...@seagullsoftware.com> wrote:
>> -----Original Message-----
>> From: Phil Steitz [mailto:phil.steitz@gmail.com]
>> Sent: Sunday, August 02, 2009 6:19 PM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
>>
>> Niall Pemberton wrote:
>> > I have prepared a third release candidate for Codec 1.4 following the
>> > feedback from the first.
>> >
>> > [ ] +1 Yes go ahead an release based on RC3
>> > [ ] -1 No, because...
>> >
>> > The tag for RC3 is here:
>> > http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>> >
>> > The release artefacts are here
>> > http://people.apache.org/~niallp/codec-1.4-rc3/
>> >
>> > Site is available here:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
>> > (note: some links are relative and will be broken until deployed to
>> > proper codec home)
>> >
>> > RAT Report:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>> >
>> > CLIRR Report:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>> >
>> > Release Notes:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
>> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>> >
>> > Thanks
>> >
>> > Niall
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
> Niall, thank you for cutting the RC.
>
> The default.properties file contains:
>
> junit.jar = ${junit.home}/junit-3.8.2.jar
>
> The JUnit 3.8.2 download contains junit.jar, not junit-3.8.2.jar. I have made the change in SVN.
>
>> Sigs and hashes are good and both ant and maven builds work fine on jdk
>> 1.4-1.6.
>>
>> I see there are 2 issues open with fix version = 1.4 and 3 more that are
>> uncategorized.
>>
>> I am +1 on this release assuming the open issues can be assigned to a
>> later release.
>>
>> Are all of the files in the top-level directory of the source
>> distribution necessary, still-maintainted, and relevant?
>
> Phil, you must be talking about the -src file, as opposed to the -bin version. The -bin zip looks clean, no extra files at the root there.
>
> For the -src zip file:
>
> It is a bit odd to have a RELEASE-NOTES file for each release. I usually see one file that contains just the information for the current release or the whole history, one release after another, which is my preference (from newest to oldest release.)
>
> The RELEASE-NOTES files for older version are in a different format that our current nice and clean format for 1.4, but I would still rather see all the history in one file, no matter what the format.
>
> The RELEASE-PLAN file is not up to date since it does not contain an entry for release 1.4. IMO, it should be removed or updated. As it is now, it does not have much value.

I've removed the RELEASE-PLAN document

> I do not think we need to deliver LICENSE-header.txt. It is nice to have in SVN for developers but I am pretty sure the build does not use it, unless mavens checks to see that each Java source file starts with those bits?

LICENSE-header.txt is used by checkstyle in the maven2 build to check
the java source files start with the standard ASF header

Niall


> Gary
>
>>
>> Phil
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: [VOTE] Release Codec 1.4 based on RC3

Posted by Gary Gregory <GG...@seagullsoftware.com>.
> -----Original Message-----
> From: Phil Steitz [mailto:phil.steitz@gmail.com]
> Sent: Sunday, August 02, 2009 6:19 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> 
> Niall Pemberton wrote:
> > I have prepared a third release candidate for Codec 1.4 following the
> > feedback from the first.
> >
> > [ ] +1 Yes go ahead an release based on RC3
> > [ ] -1 No, because...
> >
> > The tag for RC3 is here:
> > http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
> >
> > The release artefacts are here
> > http://people.apache.org/~niallp/codec-1.4-rc3/
> >
> > Site is available here:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
> > (note: some links are relative and will be broken until deployed to
> > proper codec home)
> >
> > RAT Report:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
> >
> > CLIRR Report:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
> >
> > Release Notes:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
> >
> > Thanks
> >
> > Niall
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
Niall, thank you for cutting the RC.

The default.properties file contains:

junit.jar = ${junit.home}/junit-3.8.2.jar

The JUnit 3.8.2 download contains junit.jar, not junit-3.8.2.jar. I have made the change in SVN. 

> Sigs and hashes are good and both ant and maven builds work fine on jdk
> 1.4-1.6.
> 
> I see there are 2 issues open with fix version = 1.4 and 3 more that are
> uncategorized.
> 
> I am +1 on this release assuming the open issues can be assigned to a
> later release.
> 
> Are all of the files in the top-level directory of the source
> distribution necessary, still-maintainted, and relevant?

Phil, you must be talking about the -src file, as opposed to the -bin version. The -bin zip looks clean, no extra files at the root there. 

For the -src zip file:

It is a bit odd to have a RELEASE-NOTES file for each release. I usually see one file that contains just the information for the current release or the whole history, one release after another, which is my preference (from newest to oldest release.) 

The RELEASE-NOTES files for older version are in a different format that our current nice and clean format for 1.4, but I would still rather see all the history in one file, no matter what the format.

The RELEASE-PLAN file is not up to date since it does not contain an entry for release 1.4. IMO, it should be removed or updated. As it is now, it does not have much value.

I do not think we need to deliver LICENSE-header.txt. It is nice to have in SVN for developers but I am pretty sure the build does not use it, unless mavens checks to see that each Java source file starts with those bits?

Gary

> 
> Phil
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, Aug 3, 2009 at 9:52 AM, Gary
Gregory<GG...@seagullsoftware.com> wrote:
>
>
>> -----Original Message-----
>> From: Phil Steitz [mailto:phil.steitz@gmail.com]
>> Sent: Sunday, August 02, 2009 6:19 PM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
>>
>> Niall Pemberton wrote:
>> > I have prepared a third release candidate for Codec 1.4 following the
>> > feedback from the first.
>> >
>> > [ ] +1 Yes go ahead an release based on RC3
>> > [ ] -1 No, because...
>> >
>> > The tag for RC3 is here:
>> > http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>> >
>> > The release artefacts are here
>> > http://people.apache.org/~niallp/codec-1.4-rc3/
>> >
>> > Site is available here:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
>> > (note: some links are relative and will be broken until deployed to
>> > proper codec home)
>> >
>> > RAT Report:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>> >
>> > CLIRR Report:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>> >
>> > Release Notes:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
>> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>> >
>> > Thanks
>> >
>> > Niall
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>> Sigs and hashes are good and both ant and maven builds work fine on jdk
>> 1.4-1.6.
>>
>> I see there are 2 issues open with fix version = 1.4 and 3 more that are
>> uncategorized.
>
> I can see that [CODEC-73] is worth fixing and not too hard. I'll take a cut at updating the proposed patches to the current code base.

I have moved three issues to "1.x" and the only other one we might
consider is CODEC-55 - the thread safety issue. I am not keen on what
has been proposed - so I've attached a patch for an alternative
"wrapper" solution. Given the amount of discussion on that ticket
though, maybe it needs time to come to a consensus on what should be
implemented.

Niall

> Gary
>
>>
>> I am +1 on this release assuming the open issues can be assigned to a
>> later release.
>>
>> Are all of the files in the top-level directory of the source
>> distribution necessary, still-maintainted, and relevant?
>>
>> Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: [VOTE] Release Codec 1.4 based on RC3

Posted by Gary Gregory <GG...@seagullsoftware.com>.
> -----Original Message-----
> From: Niall Pemberton [mailto:niall.pemberton@gmail.com]
> Sent: Tuesday, August 04, 2009 12:53 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> 
> On Tue, Aug 4, 2009 at 6:10 PM, Gary
> Gregory<GG...@seagullsoftware.com> wrote:
> >> -----Original Message-----
> >> From: Niall Pemberton [mailto:niall.pemberton@gmail.com]
> >> Sent: Tuesday, August 04, 2009 2:38 AM
> >> To: Commons Developers List
> >> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> >>
> >> On Mon, Aug 3, 2009 at 9:52 AM, Gary
> >> Gregory<GG...@seagullsoftware.com> wrote:
> >> >
> >> >
> >> >> -----Original Message-----
> >> >> From: Phil Steitz [mailto:phil.steitz@gmail.com]
> >> >> Sent: Sunday, August 02, 2009 6:19 PM
> >> >> To: Commons Developers List
> >> >> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> >> >>
> >> >> Niall Pemberton wrote:
> >> >> > I have prepared a third release candidate for Codec 1.4 following
> the
> >> >> > feedback from the first.
> >> >> >
> >> >> > [ ] +1 Yes go ahead an release based on RC3
> >> >> > [ ] -1 No, because...
> >> >> >
> >> >> > The tag for RC3 is here:
> >> >> >
> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
> >> >> >
> >> >> > The release artefacts are here
> >> >> > http://people.apache.org/~niallp/codec-1.4-rc3/
> >> >> >
> >> >> > Site is available here:
> >> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
> >> >> > (note: some links are relative and will be broken until deployed
> to
> >> >> > proper codec home)
> >> >> >
> >> >> > RAT Report:
> >> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-
> report.html
> >> >> >
> >> >> > CLIRR Report:
> >> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-
> report.html
> >> >> >
> >> >> > Release Notes:
> >> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-
> >> report.html
> >> >> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
> >> >> >
> >> >> > Thanks
> >> >> >
> >> >> > Niall
> >> >> >
> >> >> > ------------------------------------------------------------------
> ---
> >> >> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> >> > For additional commands, e-mail: dev-help@commons.apache.org
> >> >> >
> >> >> >
> >> >> Sigs and hashes are good and both ant and maven builds work fine on
> jdk
> >> >> 1.4-1.6.
> >> >>
> >> >> I see there are 2 issues open with fix version = 1.4 and 3 more that
> >> are
> >> >> uncategorized.
> >> >
> >> > I can see that [CODEC-73] is worth fixing and not too hard. I'll take
> a
> >> cut at updating the proposed patches to the current code base.
> >>
> >> Can this go in the next release or do you want to cancel this RC/vote
> >> one and include it in the 1.4 release?
> >
> > I think there are other small issues that have added up that warrant
> another RC.
> 
> What are these? Because I only see the DigestUtils commit since RC3 was
> created.

I just recall making small changes and suggestions about the root files in the -src zip. If the community decides RC3 is good enough, well, that's fine. If we could pick up the DigestUtils changes in an RC4, that's fine too.

Gary

> 
> > WRT to this ticket in particular, it is partially addressed by the
> DigestUtils fixes I have put in. I am happy to leave the rest for the next
> release though.
> >
> 
> How about just going with whats in RC3 as the release?
> 
> Niall
> 
> > Gary
> >
> >>
> >> Niall
> >>
> >> > Gary
> >> >
> >> >>
> >> >> I am +1 on this release assuming the open issues can be assigned to
> a
> >> >> later release.
> >> >>
> >> >> Are all of the files in the top-level directory of the source
> >> >> distribution necessary, still-maintainted, and relevant?
> >> >>
> >> >> Phil
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Niall Pemberton <ni...@gmail.com>.
On Tue, Aug 4, 2009 at 6:10 PM, Gary
Gregory<GG...@seagullsoftware.com> wrote:
>> -----Original Message-----
>> From: Niall Pemberton [mailto:niall.pemberton@gmail.com]
>> Sent: Tuesday, August 04, 2009 2:38 AM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
>>
>> On Mon, Aug 3, 2009 at 9:52 AM, Gary
>> Gregory<GG...@seagullsoftware.com> wrote:
>> >
>> >
>> >> -----Original Message-----
>> >> From: Phil Steitz [mailto:phil.steitz@gmail.com]
>> >> Sent: Sunday, August 02, 2009 6:19 PM
>> >> To: Commons Developers List
>> >> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
>> >>
>> >> Niall Pemberton wrote:
>> >> > I have prepared a third release candidate for Codec 1.4 following the
>> >> > feedback from the first.
>> >> >
>> >> > [ ] +1 Yes go ahead an release based on RC3
>> >> > [ ] -1 No, because...
>> >> >
>> >> > The tag for RC3 is here:
>> >> > http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>> >> >
>> >> > The release artefacts are here
>> >> > http://people.apache.org/~niallp/codec-1.4-rc3/
>> >> >
>> >> > Site is available here:
>> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
>> >> > (note: some links are relative and will be broken until deployed to
>> >> > proper codec home)
>> >> >
>> >> > RAT Report:
>> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>> >> >
>> >> > CLIRR Report:
>> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>> >> >
>> >> > Release Notes:
>> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-
>> report.html
>> >> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>> >> >
>> >> > Thanks
>> >> >
>> >> > Niall
>> >> >
>> >> > ---------------------------------------------------------------------
>> >> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> > For additional commands, e-mail: dev-help@commons.apache.org
>> >> >
>> >> >
>> >> Sigs and hashes are good and both ant and maven builds work fine on jdk
>> >> 1.4-1.6.
>> >>
>> >> I see there are 2 issues open with fix version = 1.4 and 3 more that
>> are
>> >> uncategorized.
>> >
>> > I can see that [CODEC-73] is worth fixing and not too hard. I'll take a
>> cut at updating the proposed patches to the current code base.
>>
>> Can this go in the next release or do you want to cancel this RC/vote
>> one and include it in the 1.4 release?
>
> I think there are other small issues that have added up that warrant another RC.

What are these? Because I only see the DigestUtils commit since RC3 was created.

> WRT to this ticket in particular, it is partially addressed by the DigestUtils fixes I have put in. I am happy to leave the rest for the next release though.
>

How about just going with whats in RC3 as the release?

Niall

> Gary
>
>>
>> Niall
>>
>> > Gary
>> >
>> >>
>> >> I am +1 on this release assuming the open issues can be assigned to a
>> >> later release.
>> >>
>> >> Are all of the files in the top-level directory of the source
>> >> distribution necessary, still-maintainted, and relevant?
>> >>
>> >> Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Julius Davies <ju...@gmail.com>.
>>
>> Can this go in the next release or do you want to cancel this RC/vote
>> one and include it in the 1.4 release?
>
> I think there are other small issues that have added up that warrant another RC. WRT to this ticket in particular, it is partially addressed by the DigestUtils fixes I have put in. I am happy to leave the rest for the next release though.
>

What's left to do?  Maybe I can help?


-- 
yours,

Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: [VOTE] Release Codec 1.4 based on RC3

Posted by Gary Gregory <GG...@seagullsoftware.com>.
> -----Original Message-----
> From: Niall Pemberton [mailto:niall.pemberton@gmail.com]
> Sent: Tuesday, August 04, 2009 2:38 AM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> 
> On Mon, Aug 3, 2009 at 9:52 AM, Gary
> Gregory<GG...@seagullsoftware.com> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Phil Steitz [mailto:phil.steitz@gmail.com]
> >> Sent: Sunday, August 02, 2009 6:19 PM
> >> To: Commons Developers List
> >> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> >>
> >> Niall Pemberton wrote:
> >> > I have prepared a third release candidate for Codec 1.4 following the
> >> > feedback from the first.
> >> >
> >> > [ ] +1 Yes go ahead an release based on RC3
> >> > [ ] -1 No, because...
> >> >
> >> > The tag for RC3 is here:
> >> > http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
> >> >
> >> > The release artefacts are here
> >> > http://people.apache.org/~niallp/codec-1.4-rc3/
> >> >
> >> > Site is available here:
> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
> >> > (note: some links are relative and will be broken until deployed to
> >> > proper codec home)
> >> >
> >> > RAT Report:
> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
> >> >
> >> > CLIRR Report:
> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
> >> >
> >> > Release Notes:
> >> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-
> report.html
> >> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
> >> >
> >> > Thanks
> >> >
> >> > Niall
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> > For additional commands, e-mail: dev-help@commons.apache.org
> >> >
> >> >
> >> Sigs and hashes are good and both ant and maven builds work fine on jdk
> >> 1.4-1.6.
> >>
> >> I see there are 2 issues open with fix version = 1.4 and 3 more that
> are
> >> uncategorized.
> >
> > I can see that [CODEC-73] is worth fixing and not too hard. I'll take a
> cut at updating the proposed patches to the current code base.
> 
> Can this go in the next release or do you want to cancel this RC/vote
> one and include it in the 1.4 release?

I think there are other small issues that have added up that warrant another RC. WRT to this ticket in particular, it is partially addressed by the DigestUtils fixes I have put in. I am happy to leave the rest for the next release though.

Gary

> 
> Niall
> 
> > Gary
> >
> >>
> >> I am +1 on this release assuming the open issues can be assigned to a
> >> later release.
> >>
> >> Are all of the files in the top-level directory of the source
> >> distribution necessary, still-maintainted, and relevant?
> >>
> >> Phil
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Niall Pemberton <ni...@gmail.com>.
On Mon, Aug 3, 2009 at 9:52 AM, Gary
Gregory<GG...@seagullsoftware.com> wrote:
>
>
>> -----Original Message-----
>> From: Phil Steitz [mailto:phil.steitz@gmail.com]
>> Sent: Sunday, August 02, 2009 6:19 PM
>> To: Commons Developers List
>> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
>>
>> Niall Pemberton wrote:
>> > I have prepared a third release candidate for Codec 1.4 following the
>> > feedback from the first.
>> >
>> > [ ] +1 Yes go ahead an release based on RC3
>> > [ ] -1 No, because...
>> >
>> > The tag for RC3 is here:
>> > http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>> >
>> > The release artefacts are here
>> > http://people.apache.org/~niallp/codec-1.4-rc3/
>> >
>> > Site is available here:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
>> > (note: some links are relative and will be broken until deployed to
>> > proper codec home)
>> >
>> > RAT Report:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>> >
>> > CLIRR Report:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>> >
>> > Release Notes:
>> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
>> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>> >
>> > Thanks
>> >
>> > Niall
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>> >
>> Sigs and hashes are good and both ant and maven builds work fine on jdk
>> 1.4-1.6.
>>
>> I see there are 2 issues open with fix version = 1.4 and 3 more that are
>> uncategorized.
>
> I can see that [CODEC-73] is worth fixing and not too hard. I'll take a cut at updating the proposed patches to the current code base.

Can this go in the next release or do you want to cancel this RC/vote
one and include it in the 1.4 release?

Niall

> Gary
>
>>
>> I am +1 on this release assuming the open issues can be assigned to a
>> later release.
>>
>> Are all of the files in the top-level directory of the source
>> distribution necessary, still-maintainted, and relevant?
>>
>> Phil
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: [VOTE] Release Codec 1.4 based on RC3

Posted by Gary Gregory <GG...@seagullsoftware.com>.

> -----Original Message-----
> From: Phil Steitz [mailto:phil.steitz@gmail.com]
> Sent: Sunday, August 02, 2009 6:19 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> 
> Niall Pemberton wrote:
> > I have prepared a third release candidate for Codec 1.4 following the
> > feedback from the first.
> >
> > [ ] +1 Yes go ahead an release based on RC3
> > [ ] -1 No, because...
> >
> > The tag for RC3 is here:
> > http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
> >
> > The release artefacts are here
> > http://people.apache.org/~niallp/codec-1.4-rc3/
> >
> > Site is available here:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/
> > (note: some links are relative and will be broken until deployed to
> > proper codec home)
> >
> > RAT Report:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
> >
> > CLIRR Report:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
> >
> > Release Notes:
> > http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
> > http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
> >
> > Thanks
> >
> > Niall
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
> Sigs and hashes are good and both ant and maven builds work fine on jdk
> 1.4-1.6.
> 
> I see there are 2 issues open with fix version = 1.4 and 3 more that are
> uncategorized.

I can see that [CODEC-73] is worth fixing and not too hard. I'll take a cut at updating the proposed patches to the current code base.

Gary

> 
> I am +1 on this release assuming the open issues can be assigned to a
> later release.
> 
> Are all of the files in the top-level directory of the source
> distribution necessary, still-maintainted, and relevant?
> 
> Phil
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Phil Steitz <ph...@gmail.com>.
Niall Pemberton wrote:
> I have prepared a third release candidate for Codec 1.4 following the
> feedback from the first.
>
> [ ] +1 Yes go ahead an release based on RC3
> [ ] -1 No, because...
>
> The tag for RC3 is here:
> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>
> The release artefacts are here
> http://people.apache.org/~niallp/codec-1.4-rc3/
>
> Site is available here:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/
> (note: some links are relative and will be broken until deployed to
> proper codec home)
>
> RAT Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>
> CLIRR Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>
> Release Notes:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
> http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>
> Thanks
>
> Niall
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>   
Sigs and hashes are good and both ant and maven builds work fine on jdk 
1.4-1.6. 

I see there are 2 issues open with fix version = 1.4 and 3 more that are 
uncategorized. 

I am +1 on this release assuming the open issues can be assigned to a 
later release.

Are all of the files in the top-level directory of the source 
distribution necessary, still-maintainted, and relevant?

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Rahul Akolkar <ra...@gmail.com>.
On Sun, Aug 2, 2009 at 8:35 PM, Niall
Pemberton<ni...@gmail.com> wrote:
> I have prepared a third release candidate for Codec 1.4 following the
> feedback from the first.
>
> [X] +1 Yes go ahead an release based on RC3
> [ ] -1 No, because...
>
<snip/>

-Rahul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Jörg Schaible <jo...@gmx.de>.
+1, source package passes my compiler zoo

Niall Pemberton wrote:

> I have prepared a third release candidate for Codec 1.4 following the
> feedback from the first.
> 
> [ ] +1 Yes go ahead an release based on RC3
> [ ] -1 No, because...
> 
> The tag for RC3 is here:
> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
> 
> The release artefacts are here
> http://people.apache.org/~niallp/codec-1.4-rc3/
> 
> Site is available here:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/
> (note: some links are relative and will be broken until deployed to
> proper codec home)
> 
> RAT Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
> 
> CLIRR Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
> 
> Release Notes:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
> http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
> 
> Thanks
> 
> Niall



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: [VOTE] Release Codec 1.4 based on RC3

Posted by Gary Gregory <GG...@seagullsoftware.com>.
I do not mind the current ("old") method names.

Gary

> -----Original Message-----
> From: Julius Davies [mailto:juliusdavies@gmail.com]
> Sent: Wednesday, August 05, 2009 5:18 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> 
> Hi,
> 
> Some more API changes attached as patch to CODEC-86 if anyone is
> interested:  CODEC-86 - Rename method to Base64.encodeBase64ToString()
> 
> https://issues.apache.org/jira/browse/CODEC-86
> 
> If codec devs prefer the older method names, or don't care, please
> just close CODEC-86.  Very unimportant.  Or feel free to apply the
> patch.   :-)
> 
> 
> yours,
> 
> Julius
> 
> 
> ps.  "mvn test" is a bit noisy on stdout on trunk right now, and
> mildly concerning since it's printing the word FAILED a few times
> along with stacktraces, but no tests are actually failing:
> 
> [......]
> testCustomCharset=IBM870
> testCustomCharset=IBM871
> testCustomCharset=IBM918
> FAILED charsetSanityCheck=ISO-2022-CN,
> e=java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>         at sun.nio.cs.ext.ISO2022_CN.newEncoder(ISO2022_CN.java:64)
>         at
> java.lang.StringCoding$StringEncoder.<init>(StringCoding.java:215)
>         at
> java.lang.StringCoding$StringEncoder.<init>(StringCoding.java:207)
>         at java.lang.StringCoding.encode(StringCoding.java:266)
>         at java.lang.String.getBytes(String.java:947)
>         at
> org.apache.commons.codec.binary.HexTest.charsetSanityCheck(HexTest.java:52
> )
>         at
> org.apache.commons.codec.binary.HexTest.testCustomCharset(HexTest.java:144
> )
>         at
> org.apache.commons.codec.binary.HexTest.testCustomCharset(HexTest.java:132
> )
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm
> pl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at junit.framework.TestCase.runTest(TestCase.java:164)
>         at junit.framework.TestCase.runBare(TestCase.java:130)
>         at junit.framework.TestResult$1.protect(TestResult.java:106)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.framework.TestResult.run(TestResult.java:109)
>         at junit.framework.TestCase.run(TestCase.java:120)
>         at junit.framework.TestSuite.runTest(TestSuite.java:230)
>         at junit.framework.TestSuite.run(TestSuite.java:225)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm
> pl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at
> org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213
> )
>         at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(
> AbstractDirectoryTestSuite.java:1
>         at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(Abstrac
> tDirectoryTestSuite.java:127)
>         at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm
> pl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at
> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(Surefir
> eBooter.java:345)
>         at
> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1
> 009)
> testCustomCharset=ISO-2022-JP
> testCustomCharset=ISO-2022-JP-2
> testCustomCharset=ISO-2022-KR
> testCustomCharset=ISO-8859-1
> testCustomCharset=ISO-8859-13
> testCustomCharset=ISO-8859-15
> testCustomCharset=ISO-8859-2
> testCustomCharset=ISO-8859-3
> testCustomCharset=ISO-8859-4
> testCustomCharset=ISO-8859-5
> testCustomCharset=ISO-8859-6
> testCustomCharset=ISO-8859-7
> testCustomCharset=ISO-8859-8
> testCustomCharset=ISO-8859-9
> testCustomCharset=JIS_X0201
> FAILED charsetSanityCheck=Interesting Java charset oddity: Roundtrip
> failed for JIS_X0212-1990
> testCustomCharset=KOI8-R
> testCustomCharset=KOI8-U
> testCustomCharset=Shift_JIS
> testCustomCharset=TIS-620
> testCustomCharset=US-ASCII
> [...]
> 
> 
> 
> On Wed, Aug 5, 2009 at 4:09 PM, Niall
> Pemberton<ni...@gmail.com> wrote:
> > Thanks and apologies to everyone - this vote is cancelled because
> > Codec's API has changed.
> >
> > Niall
> >
> 
> 
> --
> yours,
> 
> Julius Davies
> 250-592-2284 (Home)
> 250-893-4579 (Mobile)
> http://juliusdavies.ca/logging.html
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


RE: [VOTE] Release Codec 1.4 based on RC3

Posted by Gary Gregory <GG...@seagullsoftware.com>.
> -----Original Message-----
> From: Julius Davies [mailto:juliusdavies@gmail.com]
> Sent: Wednesday, August 05, 2009 5:18 PM
> To: Commons Developers List
> Subject: Re: [VOTE] Release Codec 1.4 based on RC3
> 
> Hi,
> 
> Some more API changes attached as patch to CODEC-86 if anyone is
> interested:  CODEC-86 - Rename method to Base64.encodeBase64ToString()
> 
> https://issues.apache.org/jira/browse/CODEC-86
> 
> If codec devs prefer the older method names, or don't care, please
> just close CODEC-86.  Very unimportant.  Or feel free to apply the
> patch.   :-)
> 
> 
> yours,
> 
> Julius
> 
> 
> ps.  "mvn test" is a bit noisy on stdout on trunk right now, and
> mildly concerning since it's printing the word FAILED a few times
> along with stacktraces, but no tests are actually failing:

I have turned that off. Developers can turn it on via the HexTest.LOG private final static boolean.

Gary

> 
> [......]
> testCustomCharset=IBM870
> testCustomCharset=IBM871
> testCustomCharset=IBM918
> FAILED charsetSanityCheck=ISO-2022-CN,
> e=java.lang.UnsupportedOperationException
> java.lang.UnsupportedOperationException
>         at sun.nio.cs.ext.ISO2022_CN.newEncoder(ISO2022_CN.java:64)
>         at
> java.lang.StringCoding$StringEncoder.<init>(StringCoding.java:215)
>         at
> java.lang.StringCoding$StringEncoder.<init>(StringCoding.java:207)
>         at java.lang.StringCoding.encode(StringCoding.java:266)
>         at java.lang.String.getBytes(String.java:947)
>         at
> org.apache.commons.codec.binary.HexTest.charsetSanityCheck(HexTest.java:52
> )
>         at
> org.apache.commons.codec.binary.HexTest.testCustomCharset(HexTest.java:144
> )
>         at
> org.apache.commons.codec.binary.HexTest.testCustomCharset(HexTest.java:132
> )
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm
> pl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at junit.framework.TestCase.runTest(TestCase.java:164)
>         at junit.framework.TestCase.runBare(TestCase.java:130)
>         at junit.framework.TestResult$1.protect(TestResult.java:106)
>         at junit.framework.TestResult.runProtected(TestResult.java:124)
>         at junit.framework.TestResult.run(TestResult.java:109)
>         at junit.framework.TestCase.run(TestCase.java:120)
>         at junit.framework.TestSuite.runTest(TestSuite.java:230)
>         at junit.framework.TestSuite.run(TestSuite.java:225)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm
> pl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at
> org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213
> )
>         at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(
> AbstractDirectoryTestSuite.java:1
>         at
> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(Abstrac
> tDirectoryTestSuite.java:127)
>         at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:
> 39)
>         at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm
> pl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at
> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(Surefir
> eBooter.java:345)
>         at
> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1
> 009)
> testCustomCharset=ISO-2022-JP
> testCustomCharset=ISO-2022-JP-2
> testCustomCharset=ISO-2022-KR
> testCustomCharset=ISO-8859-1
> testCustomCharset=ISO-8859-13
> testCustomCharset=ISO-8859-15
> testCustomCharset=ISO-8859-2
> testCustomCharset=ISO-8859-3
> testCustomCharset=ISO-8859-4
> testCustomCharset=ISO-8859-5
> testCustomCharset=ISO-8859-6
> testCustomCharset=ISO-8859-7
> testCustomCharset=ISO-8859-8
> testCustomCharset=ISO-8859-9
> testCustomCharset=JIS_X0201
> FAILED charsetSanityCheck=Interesting Java charset oddity: Roundtrip
> failed for JIS_X0212-1990
> testCustomCharset=KOI8-R
> testCustomCharset=KOI8-U
> testCustomCharset=Shift_JIS
> testCustomCharset=TIS-620
> testCustomCharset=US-ASCII
> [...]
> 
> 
> 
> On Wed, Aug 5, 2009 at 4:09 PM, Niall
> Pemberton<ni...@gmail.com> wrote:
> > Thanks and apologies to everyone - this vote is cancelled because
> > Codec's API has changed.
> >
> > Niall
> >
> 
> 
> --
> yours,
> 
> Julius Davies
> 250-592-2284 (Home)
> 250-893-4579 (Mobile)
> http://juliusdavies.ca/logging.html
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Julius Davies <ju...@gmail.com>.
Hi,

Some more API changes attached as patch to CODEC-86 if anyone is
interested:  CODEC-86 - Rename method to Base64.encodeBase64ToString()

https://issues.apache.org/jira/browse/CODEC-86

If codec devs prefer the older method names, or don't care, please
just close CODEC-86.  Very unimportant.  Or feel free to apply the
patch.   :-)


yours,

Julius


ps.  "mvn test" is a bit noisy on stdout on trunk right now, and
mildly concerning since it's printing the word FAILED a few times
along with stacktraces, but no tests are actually failing:

[......]
testCustomCharset=IBM870
testCustomCharset=IBM871
testCustomCharset=IBM918
FAILED charsetSanityCheck=ISO-2022-CN, e=java.lang.UnsupportedOperationException
java.lang.UnsupportedOperationException
        at sun.nio.cs.ext.ISO2022_CN.newEncoder(ISO2022_CN.java:64)
        at java.lang.StringCoding$StringEncoder.<init>(StringCoding.java:215)
        at java.lang.StringCoding$StringEncoder.<init>(StringCoding.java:207)
        at java.lang.StringCoding.encode(StringCoding.java:266)
        at java.lang.String.getBytes(String.java:947)
        at org.apache.commons.codec.binary.HexTest.charsetSanityCheck(HexTest.java:52)
        at org.apache.commons.codec.binary.HexTest.testCustomCharset(HexTest.java:144)
        at org.apache.commons.codec.binary.HexTest.testCustomCharset(HexTest.java:132)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at junit.framework.TestCase.runTest(TestCase.java:164)
        at junit.framework.TestCase.runBare(TestCase.java:130)
        at junit.framework.TestResult$1.protect(TestResult.java:106)
        at junit.framework.TestResult.runProtected(TestResult.java:124)
        at junit.framework.TestResult.run(TestResult.java:109)
        at junit.framework.TestCase.run(TestCase.java:120)
        at junit.framework.TestSuite.runTest(TestSuite.java:230)
        at junit.framework.TestSuite.run(TestSuite.java:225)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
        at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:1
        at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
        at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
        at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
testCustomCharset=ISO-2022-JP
testCustomCharset=ISO-2022-JP-2
testCustomCharset=ISO-2022-KR
testCustomCharset=ISO-8859-1
testCustomCharset=ISO-8859-13
testCustomCharset=ISO-8859-15
testCustomCharset=ISO-8859-2
testCustomCharset=ISO-8859-3
testCustomCharset=ISO-8859-4
testCustomCharset=ISO-8859-5
testCustomCharset=ISO-8859-6
testCustomCharset=ISO-8859-7
testCustomCharset=ISO-8859-8
testCustomCharset=ISO-8859-9
testCustomCharset=JIS_X0201
FAILED charsetSanityCheck=Interesting Java charset oddity: Roundtrip
failed for JIS_X0212-1990
testCustomCharset=KOI8-R
testCustomCharset=KOI8-U
testCustomCharset=Shift_JIS
testCustomCharset=TIS-620
testCustomCharset=US-ASCII
[...]



On Wed, Aug 5, 2009 at 4:09 PM, Niall
Pemberton<ni...@gmail.com> wrote:
> Thanks and apologies to everyone - this vote is cancelled because
> Codec's API has changed.
>
> Niall
>


-- 
yours,

Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Niall Pemberton <ni...@gmail.com>.
Thanks and apologies to everyone - this vote is cancelled because
Codec's API has changed.

Niall

On Mon, Aug 3, 2009 at 1:35 AM, Niall
Pemberton<ni...@gmail.com> wrote:
> I have prepared a third release candidate for Codec 1.4 following the
> feedback from the first.
>
> [ ] +1 Yes go ahead an release based on RC3
> [ ] -1 No, because...
>
> The tag for RC3 is here:
> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>
> The release artefacts are here
> http://people.apache.org/~niallp/codec-1.4-rc3/
>
> Site is available here:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/
> (note: some links are relative and will be broken until deployed to
> proper codec home)
>
> RAT Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>
> CLIRR Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>
> Release Notes:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
> http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>
> Thanks
>
> Niall
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Niall Pemberton <ni...@gmail.com>.
On Wed, Aug 5, 2009 at 3:13 AM, Julius Davies<ju...@gmail.com> wrote:
> Hi, Codec developers,
>
>
> I dropped commons-codec-1.4.jar into IntelliJ 7.0 (my current editor)
> to see how the auto-completion looks.  Now I'm having second thoughts
> on two method names for CODEC-59.  Here's what it currently looks
> like:
>
> Base64.encodeBase64String(byte[] binaryData)
> Base64.encodeBase64URLSafeString(byte[] binaryData)
>
> http://juliusdavies.ca/codec/base64String.png
> (screenshot from IntelliJ 7, 15KB, 760x187)
>
>
> I'm wondering if the word "To" should be inserted there?  As in "ToString":
>
> Base64.encodeBase64ToString(byte[] binaryData)
> Base64.encodeBase64URLSafeToString(byte[] binaryData)
>
> http://juliusdavies.ca/codec/base64ToString.png
> (screenshot from IntelliJ 7, 14KB, 736x162)
>
>
> Sorry about this inane niggling.  I just thought it's either now or
> never!

Yes, once the API's released then its not going to change, so if the
Codec devs want to do this, then we need to do it now and roll another
RC. Anyone got a strong opinion on this?

Niall

>  Any one else have opinions about this extremely minor cosmetic
> point?  (Good bikeshedding candidate, but still... somehow
> aesthetically bothersome?)
>
>
> yours,
>
> Julius
>
>
> ps. Niall, I downloaded all the artifacts from
> http://people.apache.org/~niallp/codec-1.4-rc3/ and they look great.
> Ant and Maven builds working great from all *-src artifacts.
>
>
>
> On Tue, Aug 4, 2009 at 5:46 PM, Niall
> Pemberton<ni...@gmail.com> wrote:
>> +1
>>
>> Niall
>>
>> On Mon, Aug 3, 2009 at 1:35 AM, Niall
>> Pemberton<ni...@gmail.com> wrote:
>>> I have prepared a third release candidate for Codec 1.4 following the
>>> feedback from the first.
>>>
>>> [ ] +1 Yes go ahead an release based on RC3
>>> [ ] -1 No, because...
>>>
>>> The tag for RC3 is here:
>>> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>>>
>>> The release artefacts are here
>>> http://people.apache.org/~niallp/codec-1.4-rc3/
>>>
>>> Site is available here:
>>> http://people.apache.org/~niallp/codec-1.4-rc3/site/
>>> (note: some links are relative and will be broken until deployed to
>>> proper codec home)
>>>
>>> RAT Report:
>>> http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>>>
>>> CLIRR Report:
>>> http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>>>
>>> Release Notes:
>>> http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
>>> http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>>>
>>> Thanks
>>>
>>> Niall
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
>
> --
> yours,
>
> Julius Davies
> 250-592-2284 (Home)
> 250-893-4579 (Mobile)
> http://juliusdavies.ca/logging.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Julius Davies <ju...@gmail.com>.
Hi, Codec developers,


I dropped commons-codec-1.4.jar into IntelliJ 7.0 (my current editor)
to see how the auto-completion looks.  Now I'm having second thoughts
on two method names for CODEC-59.  Here's what it currently looks
like:

Base64.encodeBase64String(byte[] binaryData)
Base64.encodeBase64URLSafeString(byte[] binaryData)

http://juliusdavies.ca/codec/base64String.png
(screenshot from IntelliJ 7, 15KB, 760x187)


I'm wondering if the word "To" should be inserted there?  As in "ToString":

Base64.encodeBase64ToString(byte[] binaryData)
Base64.encodeBase64URLSafeToString(byte[] binaryData)

http://juliusdavies.ca/codec/base64ToString.png
(screenshot from IntelliJ 7, 14KB, 736x162)


Sorry about this inane niggling.  I just thought it's either now or
never!  Any one else have opinions about this extremely minor cosmetic
point?  (Good bikeshedding candidate, but still... somehow
aesthetically bothersome?)


yours,

Julius


ps. Niall, I downloaded all the artifacts from
http://people.apache.org/~niallp/codec-1.4-rc3/ and they look great.
Ant and Maven builds working great from all *-src artifacts.



On Tue, Aug 4, 2009 at 5:46 PM, Niall
Pemberton<ni...@gmail.com> wrote:
> +1
>
> Niall
>
> On Mon, Aug 3, 2009 at 1:35 AM, Niall
> Pemberton<ni...@gmail.com> wrote:
>> I have prepared a third release candidate for Codec 1.4 following the
>> feedback from the first.
>>
>> [ ] +1 Yes go ahead an release based on RC3
>> [ ] -1 No, because...
>>
>> The tag for RC3 is here:
>> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>>
>> The release artefacts are here
>> http://people.apache.org/~niallp/codec-1.4-rc3/
>>
>> Site is available here:
>> http://people.apache.org/~niallp/codec-1.4-rc3/site/
>> (note: some links are relative and will be broken until deployed to
>> proper codec home)
>>
>> RAT Report:
>> http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>>
>> CLIRR Report:
>> http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>>
>> Release Notes:
>> http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
>> http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>>
>> Thanks
>>
>> Niall
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



-- 
yours,

Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by Niall Pemberton <ni...@gmail.com>.
+1

Niall

On Mon, Aug 3, 2009 at 1:35 AM, Niall
Pemberton<ni...@gmail.com> wrote:
> I have prepared a third release candidate for Codec 1.4 following the
> feedback from the first.
>
> [ ] +1 Yes go ahead an release based on RC3
> [ ] -1 No, because...
>
> The tag for RC3 is here:
> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
>
> The release artefacts are here
> http://people.apache.org/~niallp/codec-1.4-rc3/
>
> Site is available here:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/
> (note: some links are relative and will be broken until deployed to
> proper codec home)
>
> RAT Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
>
> CLIRR Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
>
> Release Notes:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
> http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
>
> Thanks
>
> Niall
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Codec 1.4 based on RC3

Posted by lu...@free.fr.
----- "Niall Pemberton" <ni...@gmail.com> a écrit :

> I have prepared a third release candidate for Codec 1.4 following the
> feedback from the first.
> 
> [ ] +1 Yes go ahead an release based on RC3

+1

Luc

> [ ] -1 No, because...
> 
> The tag for RC3 is here:
> http://svn.apache.org/viewvc/commons/proper/codec/tags/CODEC_1_4_RC3/
> 
> The release artefacts are here
> http://people.apache.org/~niallp/codec-1.4-rc3/
> 
> Site is available here:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/
> (note: some links are relative and will be broken until deployed to
> proper codec home)
> 
> RAT Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/rat-report.html
> 
> CLIRR Report:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/clirr-report.html
> 
> Release Notes:
> http://people.apache.org/~niallp/codec-1.4-rc3/site/changes-report.html
> http://people.apache.org/~niallp/codec-1.4-rc3/RELEASE-NOTES.txt
> 
> Thanks
> 
> Niall
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org