You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/09/17 09:57:41 UTC

[I] [Studio][Bug] Aliyun cloud catalog hides unsuccessful OpenAPI responses as empty or missing resources [rocketmq-dashboard]

zmuxuny opened a new issue, #4505:
URL: https://github.com/apache/rocketmq-dashboard/issues/4505

   ### Before Creating the Bug Report
   
   - [x] I searched open/closed issues and pull requests for Aliyun catalog response handling, `ListRegions`, `ListInstances`, and `GetInstance`.
   - [x] I verified the behavior on current `master` (`987b748e8f4f421c5cd3c4c4e51a064cc7e59f18`).
   
   ### Problem
   
   `AliyunCatalogService` treats any normally completed SDK future as a successful cloud-catalog read and only inspects `data`. The pinned Aliyun RocketMQ 5.x SDK response bodies for `ListRegions`, `ListInstances`, and `GetInstance` all expose business-level `success`, `code`, and `message` fields.
   
   When those APIs return a decoded body with `success=false`, current behavior converts the provider failure into misleading catalog state:
   
   - `ListRegions`: returns an empty region list;
   - `ListInstances`: stops pagination and returns an empty/partial instance list;
   - `GetInstance`: turns the provider failure into `404 Aliyun instance not found`.
   
   ### Impact
   
   These paths drive credential-backed region selection, cloud-instance discovery, and instance onboarding. Permission, throttling, account, or provider-side business failures can therefore look like "no regions", "no instances", or "instance does not exist", sending operators toward the wrong diagnosis.
   
   ### Expected behavior
   
   A decoded catalog response body with `success != true` fails closed with a 502-style `BusinessException`, retaining the provider `message`/`code` when available. A genuine successful response with empty/null data keeps the existing empty/not-found semantics. SDK exceptional completions remain mapped by `AliyunClientFactory`.
   
   ### Verification plan
   
   Add deterministic service tests for `ListRegions`, `ListInstances`, and `GetInstance` that return normally completed SDK responses with `success=false` and prove current code returns empty/not-found results. Then make those same responses fail closed while retaining the existing successful-empty and identifier-normalization behavior.
   
   This complements #4498/#4499 (Aliyun mutations) and #4500/#4504 (runtime provider reads); it covers the separate cloud-catalog/onboarding surface.
   
   AI-assisted source audit; the response contracts were verified against the pinned `alibabacloud-rocketmq20220801:5.0.8` jar.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Aliyun cloud catalog hides unsuccessful OpenAPI responses as empty or missing resources [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4505:
URL: https://github.com/apache/rocketmq-dashboard/issues/4505#issuecomment-5712551325

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   Verified against current `master` (987b748e). The analysis is accurate:
   
   - `AliyunCatalogService.listRegions()`, `listInstances()`, and `getInstance()` call Aliyun SDK methods but never inspect `success()` on the response. The code proceeds to extract `.data()` regardless of whether the API returned `success=false`.
   - The verification plan in the issue is thorough — the proposed fix (check `success()` before consuming `.data()`, map known error codes to `CatalogException`, and add tests with a stubbed client) is straightforward and correct.
   - The risk is real: a throttled or partially-authorized credential could cause the catalog to silently present an empty region list or missing instance, making the Studio appear misconfigured when the actual problem is an unchecked API error.
   
   **Severity:** Medium — affects users connecting Studio to Aliyun cloud with credentials that have partial permissions or hit throttling.
   **Impact:** Silent data loss in catalog views; operators see empty/missing resources instead of an actionable error.
   
   An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation.
   
   ---
   *Automated evaluation by github-manager*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Aliyun cloud catalog hides unsuccessful OpenAPI responses as empty or missing resources [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4505:
URL: https://github.com/apache/rocketmq-dashboard/issues/4505#issuecomment-5824476763

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Studio][Bug] Aliyun cloud catalog hides unsuccessful OpenAPI responses as empty or missing resources [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4505: [Studio][Bug] Aliyun cloud catalog hides unsuccessful OpenAPI responses as empty or missing resources
URL: https://github.com/apache/rocketmq-dashboard/issues/4505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org