You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/07 06:53:13 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #3870: systemvm: list
systemvm does not return agent state and version
rhtyd opened a new pull request #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870
This makes the listSystemVms API to return the host status (agent state),
version and last pinged information. This makes it possible for UIs
to call a single API to get this information.
This is largely for Primate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583259418
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583259389
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583289113
That's not very critical, but let me check if it's a quick one. I originally wanted to limit the scope just to apis, wrt Primate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583266224
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583288297
code LGTM
@rhtyd can you make some changes on 4.13/4.14 UI ? the agent state is determined in a complicated way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583357579
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583337162
@DaanHoogland ui works.
However, lastping returns wrong date/time. we have same issue on other api response. we can fix them together afterwards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583357448
sounds like a ugly bug @weizhouapache shift by ten bits != /1000. I think we should move away from the bit shifting when dealing with milliseconds.
Would you consider this not to be a blocker for this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583317645
ok, @rhtyd I'm fine with it. merge at will.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583331547
@weizhouapache can you confirm the ui?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583330702
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache edited a comment on issue #3870:
systemvm: list systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583337162
@DaanHoogland ui works.
However, lastping returns wrong date/time. we have same issue on other api response. we can fix them together afterwards.
@DaanHoogland
(1)we have "System.currentTimeMillis() >> 10" in many files, should it be "System.currentTimeMillis() / 1000" ?
(2) considering lastPing saves the timestamp in seconds, we need to display date by "new Date(timestamp * 1000)". If we do not change the ">>10" to 1000, we should use 1024 here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache edited a comment on issue #3870:
systemvm: list systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583337162
@DaanHoogland ui works.
However, lastping returns wrong date/time. we have same issue on other api response. we can fix them together afterwards.
@DaanHoogland we have "System.currentTimeMillis() >> 10" in many files, should it be "System.currentTimeMillis() / 1000" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583266312
@shwstppr @Pearl1594 please review as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583266003
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3870:
systemvm: list systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#discussion_r376267988
##########
File path: api/src/main/java/org/apache/cloudstack/api/response/SystemVmResponse.java
##########
@@ -138,6 +138,10 @@
@Param(description = "the state of the system VM")
private String state;
+ @SerializedName("agentstate")
+ @Param(description = "the agent state of the system VM")
Review comment:
can we add `since` key here as these are new response params
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583318536
Thanks @DaanHoogland will merge after smoketests and some UI confirmation (cc @weizhouapache)
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583265715
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583318772
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583358422
@weizhouapache cc @DaanHoogland I used the same logic as here: https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java#L105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583363986
@DaanHoogland what I said is not a blocker. I am ok with this PR.
@rhtyd yes, it has same issue. In response of listhosts and listsystemvms, both shows the last ping time is "1970-01-XXXX" instead of "2020-02-XXXX". we can fix it in the future, not today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] weizhouapache edited a comment on issue #3870:
systemvm: list systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583337162
@DaanHoogland ui works.
However, lastping returns wrong date/time. we have same issue on other api response. we can fix them together afterwards.
@DaanHoogland
(1)we have "System.currentTimeMillis() >> 10" in many files, should it be "System.currentTimeMillis() / 1000" ?
(2) considering lastPing saves the timestamp in seconds, we need to display date by "new Date(timestamp * 1000)".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583357738
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583287665
@DaanHoogland the technical preview targets 4.14, without this fix the implementation in Primate would be complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] Pearl1594 commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583279351
LGTM - agentstate, lastpinged and version fields seem to be added to the list systemvms response
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3870: systemvm: list
systemvm does not return agent state and version
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3870: systemvm: list systemvm does not return agent state and version
URL: https://github.com/apache/cloudstack/pull/3870#issuecomment-583318262
@shwstppr thanks, fixed the `since` in params response keys.
@weizhouapache I've fixed the UI as well. Can you review and test the API/UI changes? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services