You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/01 19:16:49 UTC

[GitHub] [airflow] ephraimbuddy opened a new pull request #19941: Lock TI when decrementing try_number for sensor

ephraimbuddy opened a new pull request #19941:
URL: https://github.com/apache/airflow/pull/19941


   We have a bug where try_number can go negative for sensors and I figured
   that we don't lock the task instance when handling the reschedule exception.
   This PR applies a Lock on the TI during reschedule handling
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy commented on pull request #19941: Lock TI when decrementing try_number for sensor

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #19941:
URL: https://github.com/apache/airflow/pull/19941#issuecomment-984500275


   May not be the solution...will open when I'm able to reproduce it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ephraimbuddy closed pull request #19941: Lock TI when decrementing try_number for sensor

Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed pull request #19941:
URL: https://github.com/apache/airflow/pull/19941


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org