You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by laurentgo <gi...@git.apache.org> on 2016/03/28 22:52:34 UTC
[GitHub] drill pull request: DRILL-4546: Only generate one zip archive when...
GitHub user laurentgo opened a pull request:
https://github.com/apache/drill/pull/449
DRILL-4546: Only generate one zip archive when using apache-release profile
Drill root pom doesn't override completely Apache parent pom configuration
regarding assemblies, which caused a zip archive of the project to be generated
twice, and deployed to a remote server twice too.
The fix updated the Apache parent pom version, and uses the plugin properties
to override the configuration. Also remove Drill source assembly descriptor as
the Apache parent project provides the same one.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laurentgo/drill laurent/fix-assembly-descriptor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/449.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #449
----
commit 6353b057361f40f2ec56942e77321cd84147f340
Author: Laurent Goujon <la...@dremio.com>
Date: 2016-03-28T20:31:53Z
DRILL-4546: Only generate one zip archive when using apache-release profile
Drill root pom doesn't override completely Apache parent pom configuration
regarding assemblies, which caused a zip archive of the project to be generated
twice, and deployed to a remote server twice too.
The fix updated the Apache parent pom version, and uses the plugin properties
to override the configuration. Also remove Drill source assembly descriptor as
the Apache parent project provides the same one.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4546: Only generate one zip archive when...
Posted by laurentgo <gi...@git.apache.org>.
Github user laurentgo commented on the pull request:
https://github.com/apache/drill/pull/449#issuecomment-208578452
The only changes to the resulting src bundles are the changes to pom.xml file, the missing assembly file which has been removed by the patch and changes to the git.properties file (because of the patch commit).
The distributions tar.gz have the same git.properties difference + some jar differences (which are likely caused by differences in the META-INF/METADATA.MF). There's no file missing or added
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4546: Only generate one zip archive when...
Posted by jacques-n <gi...@git.apache.org>.
Github user jacques-n commented on the pull request:
https://github.com/apache/drill/pull/449#issuecomment-204617555
Can you confirm that the release artifacts do not change between applying this and not applying it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---