You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/08 16:21:02 UTC
[GitHub] [geode] mhansonp opened a new pull request #5076: Geode 7812: Changes to PutAllClientServerDistributionTest
mhansonp opened a new pull request #5076:
URL: https://github.com/apache/geode/pull/5076
Fixed issues causing testEventIdOutOfOrderInPartitionRegionSingleHop to fail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] agingade commented on a change in pull request #5076: Geode 7812: Changes to PutAllClientServerDistributionTest
Posted by GitBox <gi...@apache.org>.
agingade commented on a change in pull request #5076:
URL: https://github.com/apache/geode/pull/5076#discussion_r422355197
##########
File path: geode-cq/src/distributedTest/java/org/apache/geode/internal/cache/PutAllClientServerDistributedTest.java
##########
@@ -2305,24 +2300,21 @@ public void testEventIdMisorderInPRSingleHop() {
myRegion.getAttributesMutator().addCacheListener(new CountingCacheListener<>(clientCounter));
myRegion.registerInterest("ALL_KEYS");
+ // server1 and server2 will closeCache after created 10 keys
// server1 add slow listener
server1.invoke(() -> {
Region<String, TickerData> region = getCache().getRegion(regionName);
region.getAttributesMutator()
.addCacheListener(new SlowCountingCacheListener<>(new Action<>(Operation.CREATE,
- creates -> executorServiceRule.submit(() -> {
- closeCacheConditionally(creates, 10);
- }))));
+ creates -> closeCacheConditionally(creates, 10))));
});
// server2 add slow listener
server2.invoke(() -> {
Region<String, TickerData> region = getCache().getRegion(regionName);
region.getAttributesMutator()
.addCacheListener(new SlowCountingCacheListener<>(new Action<>(Operation.CREATE,
- creates -> executorServiceRule.submit(() -> {
- closeCacheConditionally(creates, 10);
- }))));
+ creates -> closeCacheConditionally(creates, 30))));
Review comment:
It could so happen the number of buckets on this server could be less than 30; making putAll to success, changing it to less number will help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org