You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/10 08:11:44 UTC
[GitHub] [apisix-dashboard] ericsyh opened a new pull request #1735: fix: inconsistent displayname of updatetime on en
ericsyh opened a new pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735
Signed-off-by: Eric Shen <er...@outlook.com>
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
There is an in inconsistent display name on the Route, Upstream and SSL pages:
* Route page
<img width="932" alt="route" src="https://user-images.githubusercontent.com/10498732/114263219-da752380-9a16-11eb-8eb7-14b4557822bc.PNG">
* Upstream page
<img width="933" alt="上游" src="https://user-images.githubusercontent.com/10498732/114263228-e3fe8b80-9a16-11eb-9a97-e585520e6127.PNG">
* SSL page
<img width="925" alt="SSL" src="https://user-images.githubusercontent.com/10498732/114263244-faa4e280-9a16-11eb-9059-a895417ddc87.PNG">
* Consumer page
<img width="938" alt="消费者" src="https://user-images.githubusercontent.com/10498732/114263258-0bedef00-9a17-11eb-8fad-dfae977831bc.PNG">
So i modified `component.global.updateTime` and `page.upstream.list.edit.time` to keep the display name align as **Update Time**.
**Related issues**
No related issue.
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735#issuecomment-817105290
@ericsyh luarocks.org is unstable today, please be patient. We will help you to trigger it once it's back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735#issuecomment-817583394
Deploy preview for *apisix-dashboard* processing.
Building with commit 405f3cc3f49d578c0265f1583856191b9fff73c7
https://app.netlify.com/sites/apisix-dashboard/deploys/6073fe4e834450000758acf9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ericsyh commented on pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735#issuecomment-817100327
@juzhiyuan Any command to trigger the test again? The backend e2e CI failed ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735#issuecomment-817583394
Deploy preview for *apisix-dashboard* ready!
Built with commit 405f3cc3f49d578c0265f1583856191b9fff73c7
https://deploy-preview-1735--apisix-dashboard.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735#issuecomment-819499945
@ericsyh Thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ericsyh commented on pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735#issuecomment-817105391
> @ericsyh luarocks.org is unstable today, please be patient. We will help you to trigger it once it's back.
I see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1735: fix: inconsistent displayname of updatetime under EN locale
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #1735:
URL: https://github.com/apache/apisix-dashboard/pull/1735#issuecomment-817527248
@ericsyh please sync code from branch master to pass backend e2e test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org