You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "angela (JIRA)" <ji...@apache.org> on 2011/05/17 15:20:47 UTC

[jira] [Created] (SLING-2080) Minor improvements to authentication [patch]

Minor improvements to authentication [patch]
--------------------------------------------

                 Key: SLING-2080
                 URL: https://issues.apache.org/jira/browse/SLING-2080
             Project: Sling
          Issue Type: Improvement
          Components: Authentication
            Reporter: angela
            Priority: Minor
         Attachments: SLING-2080.patch

while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).

there were two additional things i couldn't resolve:

AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
did you mean explicitly?

FormAuthenticationHandler#AuthenticationStorage:
in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2080) Minor improvements to authentication [patch]

Posted by "Felix Meschberger (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated SLING-2080:
-------------------------------------

          Component/s: JCR
                       API
    Affects Version/s: OpenID Authentication 1.0.2
                       JCR Jackrabbit Access Manager 2.1.0
                       Form Based Authentication 1.0.2
                       Auth Core 1.0.6
                       API 2.2.2
    
> Minor improvements to authentication [patch]
> --------------------------------------------
>
>                 Key: SLING-2080
>                 URL: https://issues.apache.org/jira/browse/SLING-2080
>             Project: Sling
>          Issue Type: Improvement
>          Components: API, Authentication, JCR
>    Affects Versions: OpenID Authentication 1.0.2, JCR Jackrabbit Access Manager 2.1.0, Form Based Authentication 1.0.2, Auth Core 1.0.6, API 2.2.2
>            Reporter: angela
>            Priority: Minor
>         Attachments: SLING-2080.patch
>
>
> while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).
> there were two additional things i couldn't resolve:
> AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
> did you mean explicitly?
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (SLING-2080) Minor improvements to authentication [patch]

Posted by "Carsten Ziegeler (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed SLING-2080.
-----------------------------------

    
> Minor improvements to authentication [patch]
> --------------------------------------------
>
>                 Key: SLING-2080
>                 URL: https://issues.apache.org/jira/browse/SLING-2080
>             Project: Sling
>          Issue Type: Improvement
>          Components: API, Authentication, JCR
>    Affects Versions: OpenID Authentication 1.0.2, JCR Jackrabbit Access Manager 2.1.0, Form Based Authentication 1.0.2, Auth Core 1.0.6, API 2.2.2
>            Reporter: angela
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: OpenID Authentication 1.0.4, JCR Jackrabbit Access Manager 2.1.2, Form Based Authentication 1.0.4, Auth Core 1.1.0, API 2.2.4
>
>         Attachments: SLING-2080.patch
>
>
> while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).
> there were two additional things i couldn't resolve:
> AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
> did you mean explicitly?
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (SLING-2080) Minor improvements to authentication [patch]

Posted by "Felix Meschberger (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-2080.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: API 2.2.4
                   Auth Core 1.0.8
                   Form Based Authentication 1.0.4
                   JCR Jackrabbit Access Manager 2.1.2
                   OpenID Authentication 1.0.4
         Assignee: Felix Meschberger

I have applied all patches and fixed the places according to you suggestion. So I think this can be resolved for now.
                
> Minor improvements to authentication [patch]
> --------------------------------------------
>
>                 Key: SLING-2080
>                 URL: https://issues.apache.org/jira/browse/SLING-2080
>             Project: Sling
>          Issue Type: Improvement
>          Components: API, Authentication, JCR
>    Affects Versions: OpenID Authentication 1.0.2, JCR Jackrabbit Access Manager 2.1.0, Form Based Authentication 1.0.2, Auth Core 1.0.6, API 2.2.2
>            Reporter: angela
>            Assignee: Felix Meschberger
>            Priority: Minor
>             Fix For: OpenID Authentication 1.0.4, JCR Jackrabbit Access Manager 2.1.2, Form Based Authentication 1.0.4, Auth Core 1.0.8, API 2.2.4
>
>         Attachments: SLING-2080.patch
>
>
> while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).
> there were two additional things i couldn't resolve:
> AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
> did you mean explicitly?
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (SLING-2080) Minor improvements to authentication [patch]

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated SLING-2080:
--------------------------

    Attachment: SLING-2080.patch

> Minor improvements to authentication [patch]
> --------------------------------------------
>
>                 Key: SLING-2080
>                 URL: https://issues.apache.org/jira/browse/SLING-2080
>             Project: Sling
>          Issue Type: Improvement
>          Components: Authentication
>            Reporter: angela
>            Priority: Minor
>         Attachments: SLING-2080.patch
>
>
> while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).
> there were two additional things i couldn't resolve:
> AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
> did you mean explicitly?
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2080) Minor improvements to authentication [patch]

Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145742#comment-13145742 ] 

Felix Meschberger commented on SLING-2080:
------------------------------------------

Thank you very much for providing the patch. Applied it as follows:

   api: Rev. 1198758
   auth/core: Rev. 1198757
   auth/form: Rev. 1198771
   auth/openid: Rev.1198772
   jcr/jackrabbit-accessmanager: Rev.1198774

> AbstractAuthenticationHandler#sendValid states ...

Yes, changed to "explicitly"

> FormAuthenticationHandler#AuthenticationStorage: 
> in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor,
> SessionExtractor.

Fixed in Rev. 1198776
                
> Minor improvements to authentication [patch]
> --------------------------------------------
>
>                 Key: SLING-2080
>                 URL: https://issues.apache.org/jira/browse/SLING-2080
>             Project: Sling
>          Issue Type: Improvement
>          Components: API, Authentication, JCR
>    Affects Versions: OpenID Authentication 1.0.2, JCR Jackrabbit Access Manager 2.1.0, Form Based Authentication 1.0.2, Auth Core 1.0.6, API 2.2.2
>            Reporter: angela
>            Priority: Minor
>         Attachments: SLING-2080.patch
>
>
> while having a look at the sling authentication code i fixed some javadoc errors, missing annotations and redundant/inconsistent code fragments that i came across... feel free to include the attached patch (or parts of it).
> there were two additional things i couldn't resolve:
> AbstractAuthenticationHandler#sendValid states: " // expressely tell we have no content but set content type"
> did you mean explicitly?
> FormAuthenticationHandler#AuthenticationStorage:
> in this interface and its implementing class the javadoc is broken and refers to CookieAuthData, CookieAuthenticationHandler, CookieExtractor, SessionExtractor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira