You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/08/29 17:17:28 UTC

[GitHub] [thrift] nithinkdb commented on a diff in pull request #2645: Added conditional support in xhr

nithinkdb commented on code in PR #2645:
URL: https://github.com/apache/thrift/pull/2645#discussion_r957602390


##########
lib/nodejs/lib/thrift/xhr_connection.js:
##########
@@ -102,13 +103,22 @@ XHRConnection.prototype.flush = function() {
 
   var xreq = this.getXmlHttpRequestObject();
 
+  if (this.protocol == TBinaryProtocol) {

Review Comment:
   Ya, each connection within thrift has an associated protocol for encoding as well as a transport type. We use an HTTP connection within the nodeconnector, and we encode that information with a binary protocol and send it in chunks (bufffered transport).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org