You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/19 04:19:07 UTC
[GitHub] [incubator-tvm] areusch opened a new pull request #6940: fix tvm.relay.build() docs
areusch opened a new pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940
Looks like some line breaks are corrupting the `tvm.relay.build` [docs](https://tvm.apache.org/docs/api/python/relay/index.html#tvm.relay.build):
**Parameters**
- mod (IRModule) – The IR module to build. Using relay.Function is deprecated.
- target (str, tvm.target.Target, or dict of str(i.e. device/context) –
- to str/tvm.target.Target (name)) – For heterogeneous compilation, it is a dictionary indicating context to target mapping. For homogeneous compilation, it is a build target.
- optional – For heterogeneous compilation, it is a dictionary indicating context to target mapping. For homogeneous compilation, it is a build target.
- target_host (str or tvm.target.Target, optional) – Host compilation target, if target is device. When TVM compiles device specific program such as CUDA, we also need host(CPU) side code to interact with the driver setup the dimensions and parameters correctly. target_host is used to specify the host side codegen target. By default, llvm is used if it is enabled, otherwise a stackvm intepreter is used.
- params (dict of str to NDArray) – Input parameters to the graph that do not change during inference time. Used for constant folding.
- mod_name (Optional[str]) – The module name we will build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] zhiics commented on pull request #6940: fix tvm.relay.build() docs
Posted by GitBox <gi...@apache.org>.
zhiics commented on pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940#issuecomment-730508035
Can we use black to format it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on a change in pull request #6940: fix tvm.relay.build() docs
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940#discussion_r527105344
##########
File path: python/tvm/relay/build_module.py
##########
@@ -201,16 +201,14 @@ def get_params(self):
def build(mod, target=None, target_host=None, params=None, mod_name="default"):
- """Helper function that builds a Relay function to run on TVM graph
- runtime.
+ """Helper function that builds a Relay function to run on TVM graph runtime.
Parameters
----------
mod : :py:class:`~tvm.IRModule`
The IR module to build. Using relay.Function is deprecated.
- target : str, :any:`tvm.target.Target`, or dict of str(i.e. device/context
- name) to str/tvm.target.Target, optional
+ target : str, :any:`tvm.target.Target`, or dict of str(i.e. device/context name) to str/tvm.target.Target, optional
Review comment:
added around the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6940: fix tvm.relay.build() docs
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on pull request #6940: fix tvm.relay.build() docs
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940#issuecomment-730556374
@zhiics @giuseros I had tested this with `git-black.sh` and didn't see any changes, but added both black `fmt: off` and pylint `pylint: disable=line-too-long` comments around this docstring. we may want to consider some stricter validation of docstrings in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] areusch commented on pull request #6940: fix tvm.relay.build() docs
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940#issuecomment-730119198
@tqchen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] giuseros commented on a change in pull request #6940: fix tvm.relay.build() docs
Posted by GitBox <gi...@apache.org>.
giuseros commented on a change in pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940#discussion_r526761562
##########
File path: python/tvm/relay/build_module.py
##########
@@ -201,16 +201,14 @@ def get_params(self):
def build(mod, target=None, target_host=None, params=None, mod_name="default"):
- """Helper function that builds a Relay function to run on TVM graph
- runtime.
+ """Helper function that builds a Relay function to run on TVM graph runtime.
Parameters
----------
mod : :py:class:`~tvm.IRModule`
The IR module to build. Using relay.Function is deprecated.
- target : str, :any:`tvm.target.Target`, or dict of str(i.e. device/context
- name) to str/tvm.target.Target, optional
+ target : str, :any:`tvm.target.Target`, or dict of str(i.e. device/context name) to str/tvm.target.Target, optional
Review comment:
I think you need a `# pylint: disable=line-too-long` at the end of this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] giuseros commented on pull request #6940: fix tvm.relay.build() docs
Posted by GitBox <gi...@apache.org>.
giuseros commented on pull request #6940:
URL: https://github.com/apache/incubator-tvm/pull/6940#issuecomment-730550649
Hi @zhiics ,
I don't think Black can format comments, but I might be wrong
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org