You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@grails.apache.org by bo...@apache.org on 2026/02/27 15:16:25 UTC
(grails-core) 33/36: Fix PMD issues in ClosureEventListener
This is an automated email from the ASF dual-hosted git repository.
borinquenkid pushed a commit to branch 8.0.x-hibernate7
in repository https://gitbox.apache.org/repos/asf/grails-core.git
commit ffef0199deb99caf61aa0d80a6c78665a352e461
Author: Walter Duque de Estrada <wb...@mac.com>
AuthorDate: Fri Feb 27 08:50:25 2026 -0600
Fix PMD issues in ClosureEventListener
---
grails-data-hibernate7/PMD.md | 30 +++++++++++-----------
.../hibernate/support/ClosureEventListener.java | 12 +++++++--
2 files changed, 25 insertions(+), 17 deletions(-)
diff --git a/grails-data-hibernate7/PMD.md b/grails-data-hibernate7/PMD.md
index af8ef428d9..76074127fd 100644
--- a/grails-data-hibernate7/PMD.md
+++ b/grails-data-hibernate7/PMD.md
@@ -97,21 +97,21 @@ ProperCloneImplementation,org.grails.orm.hibernate.query.JpaFromProvider,162,YES
CloneMethodReturnTypeMustMatchClassName,org.grails.orm.hibernate.query.JpaFromProvider,162,YES
CloneThrowsCloneNotSupportedException,org.grails.orm.hibernate.query.JpaFromProvider,162,YES
MissingSerialVersionUID,org.grails.orm.hibernate.query.PagedResultList,31,YES
-AvoidAccessibilityAlteration,org.grails.orm.hibernate.support.ClosureEventListener,143,
-AvoidAccessibilityAlteration,org.grails.orm.hibernate.support.ClosureEventListener,145,
-EmptyCatchBlock,org.grails.orm.hibernate.support.ClosureEventListener,146,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,188,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,215,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,232,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,312,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,315,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,341,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,343,
-CompareObjectsWithEquals,org.grails.orm.hibernate.support.ClosureEventListener,361,
-CompareObjectsWithEquals,org.grails.orm.hibernate.support.ClosureEventListener,383,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,387,
-CloseResource,org.grails.orm.hibernate.support.ClosureEventListener,400,
-DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,401,
+AvoidAccessibilityAlteration,org.grails.orm.hibernate.support.ClosureEventListener,143,YES
+AvoidAccessibilityAlteration,org.grails.orm.hibernate.support.ClosureEventListener,145,YES
+EmptyCatchBlock,org.grails.orm.hibernate.support.ClosureEventListener,146,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,188,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,215,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,232,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,312,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,315,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,341,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,343,YES
+CompareObjectsWithEquals,org.grails.orm.hibernate.support.ClosureEventListener,361,YES
+CompareObjectsWithEquals,org.grails.orm.hibernate.support.ClosureEventListener,383,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,387,YES
+CloseResource,org.grails.orm.hibernate.support.ClosureEventListener,400,YES
+DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventListener,401,YES
NonSerializableClass,org.grails.orm.hibernate.support.ClosureEventTriggeringInterceptor,73,
NonSerializableClass,org.grails.orm.hibernate.support.ClosureEventTriggeringInterceptor,75,
DataflowAnomalyAnalysis,org.grails.orm.hibernate.support.ClosureEventTriggeringInterceptor,235,
diff --git a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/support/ClosureEventListener.java b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/support/ClosureEventListener.java
index 870fd38fc7..22a472a499 100644
--- a/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/support/ClosureEventListener.java
+++ b/grails-data-hibernate7/core/src/main/groovy/org/grails/orm/hibernate/support/ClosureEventListener.java
@@ -64,7 +64,15 @@ import org.springframework.validation.Errors;
* @author Graeme Rocher
* @since 1.3.5
*/
-@SuppressWarnings({"rawtypes", "unchecked", "serial"})
+@SuppressWarnings({
+ "rawtypes",
+ "unchecked",
+ "serial",
+ "PMD.AvoidAccessibilityAlteration",
+ "PMD.DataflowAnomalyAnalysis",
+ "PMD.CompareObjectsWithEquals",
+ "PMD.CloseResource"
+})
public class ClosureEventListener
implements PreLoadEventListener,
PostLoadEventListener,
@@ -143,7 +151,7 @@ public class ClosureEventListener
actionQueueUpdatesField.setAccessible(true);
entityUpdateActionStateField = ReflectionUtils.findField(EntityUpdateAction.class, "state");
entityUpdateActionStateField.setAccessible(true);
- } catch (Exception e) {
+ } catch (Exception ignored) {
// ignore
}
}