You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/08/02 23:34:31 UTC
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 9:34 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
made changes based on review comments.
Bugs: SQOOP-1143
https://issues.apache.org/jira/browse/SQOOP-1143
Repository: sqoop-sqoop2
Description (updated)
-------
commit e1043afccdafc866b376df812f3a6fd7976f777a
Author: Mengwei Ding <me...@gmail.com>
Date: Tue Jul 23 16:51:53 2013 -0700
SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
:000000 100644 0000000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java
:000000 100644 0000000... d056a34... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
:000000 100644 0000000... 5999e1c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java
:000000 100644 0000000... 17a996f... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
:000000 100644 0000000... bfc0d62... A core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java
:100644 100644 90bb327... d4c3b39... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
:100755 100755 76596b4... bb01016... M dist/src/main/server/conf/sqoop.properties
:100644 100644 62be8f4... 875729f... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 4c389cc... d1b6b9a... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
:100644 100644 04ffc3c... 616e974... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
:100644 100644 0d15329... 59a4511... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 6d9777a... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
:100644 100644 f92d107... 64c4536... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/audit/AuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java PRE-CREATION
core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java PRE-CREATION
core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
dist/src/main/server/conf/sqoop.properties 76596b4
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
Diff: https://reviews.apache.org/r/12932/diff/
Testing
-------
Do some manual test for new functionalities.
Unit test passed.
Thanks,
Mengwei Ding
Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for
operations upon metadata structures
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12932/#review25148
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Aug. 2, 2013, 9:34 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12932/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 9:34 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-1143
> https://issues.apache.org/jira/browse/SQOOP-1143
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit e1043afccdafc866b376df812f3a6fd7976f777a
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Jul 23 16:51:53 2013 -0700
>
> SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures
>
> :000000 100644 0000000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java
> :000000 100644 0000000... d056a34... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java
> :000000 100644 0000000... 5999e1c... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java
> :000000 100644 0000000... 17a996f... A core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java
> :000000 100644 0000000... bfc0d62... A core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java
> :100644 100644 90bb327... d4c3b39... M core/src/main/java/org/apache/sqoop/core/SqoopServer.java
> :100755 100755 76596b4... bb01016... M dist/src/main/server/conf/sqoop.properties
> :100644 100644 62be8f4... 875729f... M server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 4c389cc... d1b6b9a... M server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
> :100644 100644 04ffc3c... 616e974... M server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
> :100644 100644 0d15329... 59a4511... M server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 65686a8... 6d9777a... M server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 f92d107... 64c4536... M server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/audit/AuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerConstants.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerError.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java PRE-CREATION
> core/src/main/java/org/apache/sqoop/core/SqoopServer.java 90bb327
> dist/src/main/server/conf/sqoop.properties 76596b4
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 62be8f4
> server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java 4c389cc
> server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java 04ffc3c
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 65686a8
> server/src/main/java/org/apache/sqoop/handler/VersionRequestHandler.java f92d107
>
> Diff: https://reviews.apache.org/r/12932/diff/
>
>
> Testing
> -------
>
> Do some manual test for new functionalities.
>
> Unit test passed.
>
>
> Thanks,
>
> Mengwei Ding
>
>