You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Colin Ma <ju...@intel.com> on 2015/08/18 08:43:07 UTC

Review Request 37567: SQOOP-2500: Sqoop2: Findbugs: Fix the resource leak problem in ProviderAsserts and DatabaseProvider

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37567/
-----------------------------------------------------------

Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Fix the resource leak problem in ProviderAsserts and DatabaseProvider


Diffs
-----

  common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 4d6c8ec 
  common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java dd4e546 

Diff: https://reviews.apache.org/r/37567/diff/


Testing
-------


Thanks,

Colin Ma


Re: Review Request 37567: SQOOP-2500: Sqoop2: Findbugs: Fix the resource leak problem in ProviderAsserts and DatabaseProvider

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37567/#review95894
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Aug. 19, 2015, 5:14 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37567/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 5:14 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Fix the resource leak problem in ProviderAsserts and DatabaseProvider
> 
> 
> Diffs
> -----
> 
>   common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 4d6c8ec 
>   common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java dd4e546 
> 
> Diff: https://reviews.apache.org/r/37567/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Re: Review Request 37567: SQOOP-2500: Sqoop2: Findbugs: Fix the resource leak problem in ProviderAsserts and DatabaseProvider

Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37567/
-----------------------------------------------------------

(Updated Aug. 19, 2015, 5:14 a.m.)


Review request for Sqoop.


Repository: sqoop-sqoop2


Description
-------

Fix the resource leak problem in ProviderAsserts and DatabaseProvider


Diffs (updated)
-----

  common-test/src/main/java/org/apache/sqoop/common/test/asserts/ProviderAsserts.java 4d6c8ec 
  common-test/src/main/java/org/apache/sqoop/common/test/db/DatabaseProvider.java dd4e546 

Diff: https://reviews.apache.org/r/37567/diff/


Testing
-------


Thanks,

Colin Ma