You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by David Grizzanti <da...@sungard.com> on 2013/11/06 20:09:25 UTC
Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule fails
when generating usage events are enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15280/
-----------------------------------------------------------
Review request for cloudstack.
Bugs: CLOUDSTACK-5062
https://issues.apache.org/jira/browse/CLOUDSTACK-5062
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
- Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
Diffs
-----
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
Diff: https://reviews.apache.org/r/15280/diff/
Testing
-------
Testing only on 4.2
Thanks,
David Grizzanti
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule
fails when generating usage events are enabled
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15280/#review30987
-----------------------------------------------------------
Reminder -
This review has been pending for long. Request the submitter to please add relevant reviewers or seek volunteers from the community.
Thanks!
- Amogh Vasekar
On Nov. 6, 2013, 7:09 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2013, 7:09 p.m.)
>
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-5062
> https://issues.apache.org/jira/browse/CLOUDSTACK-5062
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
> - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
>
> Diff: https://reviews.apache.org/r/15280/diff/
>
>
> Testing
> -------
>
> Testing only on 4.2
>
>
> Thanks,
>
> David Grizzanti
>
>
RE: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing
Rule fails when generating usage events are enabled
Posted by Animesh Chaturvedi <an...@citrix.com>.
Pulled this one into latest 4.3 too
> -----Original Message-----
> From: daan Hoogland [mailto:noreply@reviews.apache.org] On Behalf Of
> daan Hoogland
> Sent: Friday, January 31, 2014 2:27 AM
> To: daan Hoogland
> Cc: David Grizzanti; Dennis John; cloudstack
> Subject: Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load
> Balancing Rule fails when generating usage events are enabled
>
>
>
> > On Jan. 31, 2014, 10:20 a.m., daan Hoogland wrote:
> > > ported to master and committed:
> fc796632ed984f37fdf32e6aedf26d179a70b22f
>
> 62a259ffa9b4daabcbe4f9afe9a78eadebbb7bff on 4.3-forward
>
>
> - daan
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/#review33308
> -----------------------------------------------------------
>
>
> On Jan. 22, 2014, 2:09 p.m., David Grizzanti wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/15280/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 22, 2014, 2:09 p.m.)
> >
> >
> > Review request for cloudstack and daan Hoogland.
> >
> >
> > Bugs: CLOUDSTACK-5062
> > https://issues.apache.org/jira/browse/CLOUDSTACK-5062
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating
> usage events are enabled
> >
> > Added logic so that a correct zoneID is passed when generating usage
> events while deleting load balancing rules:
> > - Added logic to
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to
> grab zone id and pass to publishUsageEvent
> >
> >
> > Diffs
> > -----
> >
> > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
> be81a3e
> >
> > Diff: https://reviews.apache.org/r/15280/diff/
> >
> >
> > Testing
> > -------
> >
> > Testing only on 4.2
> >
> >
> > Thanks,
> >
> > David Grizzanti
> >
> >
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule
fails when generating usage events are enabled
Posted by daan Hoogland <da...@gmail.com>.
> On Jan. 31, 2014, 10:20 a.m., daan Hoogland wrote:
> > ported to master and committed: fc796632ed984f37fdf32e6aedf26d179a70b22f
62a259ffa9b4daabcbe4f9afe9a78eadebbb7bff on 4.3-forward
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15280/#review33308
-----------------------------------------------------------
On Jan. 22, 2014, 2:09 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-5062
> https://issues.apache.org/jira/browse/CLOUDSTACK-5062
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
> - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
>
> Diff: https://reviews.apache.org/r/15280/diff/
>
>
> Testing
> -------
>
> Testing only on 4.2
>
>
> Thanks,
>
> David Grizzanti
>
>
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule
fails when generating usage events are enabled
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15280/#review33308
-----------------------------------------------------------
Ship it!
ported to master and committed: fc796632ed984f37fdf32e6aedf26d179a70b22f
- daan Hoogland
On Jan. 22, 2014, 2:09 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-5062
> https://issues.apache.org/jira/browse/CLOUDSTACK-5062
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
> - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
>
> Diff: https://reviews.apache.org/r/15280/diff/
>
>
> Testing
> -------
>
> Testing only on 4.2
>
>
> Thanks,
>
> David Grizzanti
>
>
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule
fails when generating usage events are enabled
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15280/#review33309
-----------------------------------------------------------
Commit 62a259ffa9b4daabcbe4f9afe9a78eadebbb7bff in branch refs/heads/4.3-forward from David Grizzanti
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=62a259f ]
CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating
usage events are enabled
Signed-off-by: Daan Hoogland <da...@onecht.net>
- ASF Subversion and Git Services
On Jan. 22, 2014, 2:09 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-5062
> https://issues.apache.org/jira/browse/CLOUDSTACK-5062
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
> - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
>
> Diff: https://reviews.apache.org/r/15280/diff/
>
>
> Testing
> -------
>
> Testing only on 4.2
>
>
> Thanks,
>
> David Grizzanti
>
>
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule
fails when generating usage events are enabled
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15280/#review33403
-----------------------------------------------------------
Commit 91ec548fc0b08aa4ff8e6aa57fab013ab9892893 in branch refs/heads/4.3 from David Grizzanti
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91ec548 ]
CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating
usage events are enabled
Signed-off-by: Daan Hoogland <da...@onecht.net>(cherry picked from commit 62a259ffa9b4daabcbe4f9afe9a78eadebbb7bff)
Signed-off-by: Animesh Chaturvedi <an...@apache.org>
- ASF Subversion and Git Services
On Jan. 22, 2014, 2:09 p.m., David Grizzanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2014, 2:09 p.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-5062
> https://issues.apache.org/jira/browse/CLOUDSTACK-5062
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
> - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
>
> Diff: https://reviews.apache.org/r/15280/diff/
>
>
> Testing
> -------
>
> Testing only on 4.2
>
>
> Thanks,
>
> David Grizzanti
>
>
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule
fails when generating usage events are enabled
Posted by David Grizzanti <da...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15280/
-----------------------------------------------------------
(Updated Jan. 22, 2014, 2:09 p.m.)
Review request for cloudstack and daan Hoogland.
Bugs: CLOUDSTACK-5062
https://issues.apache.org/jira/browse/CLOUDSTACK-5062
Repository: cloudstack-git
Description
-------
CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
- Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
Diffs
-----
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
Diff: https://reviews.apache.org/r/15280/diff/
Testing
-------
Testing only on 4.2
Thanks,
David Grizzanti
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing
Rule fails when generating usage events are enabled
Posted by David Grizzanti <da...@sungard.com>.
Hi Dan,
Sorry, I missed this email when you sent it. I double checked 4.2 today
and doesn't look like this was applied.
Here is what I currently see on 4.2
in server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java:
if (generateUsageEvent) {
// Generate usage event right after all rules were marked for
revoke
UsageEventUtils.publishUsageEvent(EventTypes.EVENT_LOAD_BALANCER_DELETE,
lb.getAccountId(), 0, lb.getId(),
null, LoadBalancingRule.class.getName(), lb.getUuid());
}
Whereas the diff was to:
--- a/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
+++ b/server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
@@ -1235,7 +1235,8 @@ public class LoadBalancingRulesManagerImpl<Type>
extends ManagerBase implements
if (generateUsageEvent) {
// Generate usage event right after all rules were marked
for revoke
- UsageEventUtils.publishUsageEvent(EventTypes.EVENT_LOAD_BALANCER_DELETE,
lb.getAccountId(), 0, lb.getId(),
+ Network network = _networkModel.getNetwork(lb.getNetworkId());
+ UsageEventUtils.publishUsageEvent(EventTypes.EVENT_LOAD_BALANCER_DELETE,
lb.getAccountId(), network.getDataCenterId(), lb.getId(),
null, LoadBalancingRule.class.getName(), lb.getUuid());
}
Thanks
On Thu, Nov 7, 2013 at 4:57 AM, Daan Hoogland <da...@gmail.com>wrote:
> H David,
>
> I think I already applied this on 4.2.
>
> On Wed, Nov 6, 2013 at 8:09 PM, David Grizzanti
> <da...@sungard.com> wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/15280/
> > -----------------------------------------------------------
> >
> > Review request for cloudstack.
> >
> >
> > Bugs: CLOUDSTACK-5062
> > https://issues.apache.org/jira/browse/CLOUDSTACK-5062
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating
> usage events are enabled
> >
> > Added logic so that a correct zoneID is passed when generating usage
> events while deleting load balancing rules:
> > - Added logic to
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab
> zone id and pass to publishUsageEvent
> >
> >
> > Diffs
> > -----
> >
> > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
> be81a3e
> >
> > Diff: https://reviews.apache.org/r/15280/diff/
> >
> >
> > Testing
> > -------
> >
> > Testing only on 4.2
> >
> >
> > Thanks,
> >
> > David Grizzanti
> >
>
>
--
David Grizzanti
Software Engineer
Sungard Availability Services
e: david.grizzanti@sungard.com
w: 215.446.1431
c: 570.575.0315
Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing
Rule fails when generating usage events are enabled
Posted by Daan Hoogland <da...@gmail.com>.
H David,
I think I already applied this on 4.2.
On Wed, Nov 6, 2013 at 8:09 PM, David Grizzanti
<da...@sungard.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/
> -----------------------------------------------------------
>
> Review request for cloudstack.
>
>
> Bugs: CLOUDSTACK-5062
> https://issues.apache.org/jira/browse/CLOUDSTACK-5062
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
>
> Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules:
> - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e
>
> Diff: https://reviews.apache.org/r/15280/diff/
>
>
> Testing
> -------
>
> Testing only on 4.2
>
>
> Thanks,
>
> David Grizzanti
>