You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/18 17:06:00 UTC
[GitHub] [orc] pavibhai opened a new pull request #873: [WIP] ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
pavibhai opened a new pull request #873:
URL: https://github.com/apache/orc/pull/873
### What changes were proposed in this pull request?
Includes Benchmark tests and Documentation for ORC-742 and ORC-743
### Why are the changes needed?
Benchmarks show the benefits of adding LazyIO during reads and the documentation explains the design of the same.
### How was this patch tested?
There is no new functionality added here so the regression tests were run and the benchmark tests were completed to verify the improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] omalley commented on pull request #873: [WIP] ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
omalley commented on pull request #873:
URL: https://github.com/apache/orc/pull/873#issuecomment-902043510
I think it is better practice to include the tests with the PR that adds the code. Since the tests are for the benchmark code, it makes sense to include them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] omalley merged pull request #873: ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
omalley merged pull request #873:
URL: https://github.com/apache/orc/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #873: [WIP] ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #873:
URL: https://github.com/apache/orc/pull/873#issuecomment-902035557
Then, could you spin off them as a new test PR, @pavibhai ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pavibhai commented on pull request #873: [WIP] ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
pavibhai commented on pull request #873:
URL: https://github.com/apache/orc/pull/873#issuecomment-902038392
> Then, could you spin off them as a new test PR, @pavibhai ?
Sorry I am confused. These are tests I am adding for the benchmarks that are being added as part of this PR. Why do you want to separate the tests into another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pavibhai commented on pull request #873: [WIP] ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
pavibhai commented on pull request #873:
URL: https://github.com/apache/orc/pull/873#issuecomment-904137302
@omalley @pgaref the benchmark and documentation PR is ready for review. Please take a look at it when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #873: [WIP] ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #873:
URL: https://github.com/apache/orc/pull/873#issuecomment-902071519
Got it if you think so, @omalley .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] omalley merged pull request #873: ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
omalley merged pull request #873:
URL: https://github.com/apache/orc/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pavibhai commented on pull request #873: [WIP] ORC-811 Benchmarks and documentation for ORC-742 and ORC-743
Posted by GitBox <gi...@apache.org>.
pavibhai commented on pull request #873:
URL: https://github.com/apache/orc/pull/873#issuecomment-902019809
> @pavibhai . Can we move some of the tests from `bench` module to normal modules? It's a little weird for `bench` module to have a test coverage because this is not executed by default.
@dongjoon-hyun These tests have been added specifically to verify the benchmark code with unit tests. The other modules already have this test coverage, so these tests should belong here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org