You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/21 20:14:14 UTC
Review Request 33403: Upgrade to virtualenv 12.1.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33403/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Upgrade to virtualenv 12.1.1
Diffs
-----
build-support/virtualenv 1cdfc7ff95fb4d2f748325610664f8912366bd2a
Diff: https://reviews.apache.org/r/33403/diff/
Testing
-------
Encountered this stack trace after upgrading to ubuntu 14.10, upgrading virtualenv got me past it:
```
$ ./rbt patch -c 33200
Bootstrapping rbtools @ 0.7.0
+ VIRTUALENV_VERSION=12.0.7
+ which python2.7
++ which python2.7
+ PY=/usr/bin/python2.7
+ echo 'Using /usr/bin/python2.7'
Using /usr/bin/python2.7
+++ dirname /home/wfarner/code/aurora/build-support/virtualenv
++ cd /home/wfarner/code/aurora/build-support
++ pwd
+ HERE=/home/wfarner/code/aurora/build-support
+ '[' -f /home/wfarner/code/aurora/build-support/virtualenv-12.0.7/BOOTSTRAPPED ']'
+ exec /usr/bin/python2.7 /home/wfarner/code/aurora/build-support/virtualenv-12.0.7/virtualenv.py /home/wfarner/code/aurora/build-support/rbt.venv
New python executable in /home/wfarner/code/aurora/build-support/rbt.venv/bin/python2.7
Also creating executable in /home/wfarner/code/aurora/build-support/rbt.venv/bin/python
Installing setuptools, pip...done.
You are using pip version 6.0.8, however version 6.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting RBTools==0.7.0
Exception:
Traceback (most recent call last):
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/basecommand.py", line 232, in main
status = self.run(options, args)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/commands/install.py", line 339, in run
requirement_set.prepare_files(finder)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/req/req_set.py", line 333, in prepare_files
upgrade=self.upgrade,
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 351, in find_requirement
for page in self._get_pages(locations, req):
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 566, in _get_pages
page = self._get_page(location, req)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 783, in _get_page
return HTMLPage.get_page(link, req, session=self.session)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 872, in get_page
"Cache-Control": "max-age=600",
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 473, in get
return self.request('GET', url, **kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/download.py", line 365, in request
return super(PipSession, self).request(method, url, *args, **kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 461, in request
resp = self.send(prep, **send_kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 599, in send
history = [resp for resp in gen] if allow_redirects else []
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 192, in resolve_redirects
allow_redirects=False,
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/cachecontrol/adapter.py", line 43, in send
resp = super(CacheControlAdapter, self).send(request, **kw)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/adapters.py", line 370, in send
timeout=timeout
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 518, in urlopen
body=body, headers=headers)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 322, in _make_request
self._validate_conn(conn)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 727, in _validate_conn
conn.connect()
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connection.py", line 238, in connect
ssl_version=resolved_ssl_version)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py", line 253, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/usr/lib/python2.7/ssl.py", line 350, in wrap_socket
_context=self)
File "/usr/lib/python2.7/ssl.py", line 563, in __init__
self.close()
File "/usr/lib/python2.7/ssl.py", line 758, in close
if self._makefile_refs < 1:
AttributeError: 'SSLSocket' object has no attribute '_makefile_refs'
```
Thanks,
Bill Farner
Re: Review Request 33403: Upgrade to virtualenv 12.1.1
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33403/
-----------------------------------------------------------
(Updated April 21, 2015, 6:35 p.m.)
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description (updated)
-------
Upgrade to virtualenv 12.1.1
Encountered this stack trace after upgrading to ubuntu 14.10, upgrading virtualenv got me past it:
```
$ ./rbt patch -c 33200
Bootstrapping rbtools @ 0.7.0
+ VIRTUALENV_VERSION=12.0.7
+ which python2.7
++ which python2.7
+ PY=/usr/bin/python2.7
+ echo 'Using /usr/bin/python2.7'
Using /usr/bin/python2.7
+++ dirname /home/wfarner/code/aurora/build-support/virtualenv
++ cd /home/wfarner/code/aurora/build-support
++ pwd
+ HERE=/home/wfarner/code/aurora/build-support
+ '[' -f /home/wfarner/code/aurora/build-support/virtualenv-12.0.7/BOOTSTRAPPED ']'
+ exec /usr/bin/python2.7 /home/wfarner/code/aurora/build-support/virtualenv-12.0.7/virtualenv.py /home/wfarner/code/aurora/build-support/rbt.venv
New python executable in /home/wfarner/code/aurora/build-support/rbt.venv/bin/python2.7
Also creating executable in /home/wfarner/code/aurora/build-support/rbt.venv/bin/python
Installing setuptools, pip...done.
You are using pip version 6.0.8, however version 6.1.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Collecting RBTools==0.7.0
Exception:
Traceback (most recent call last):
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/basecommand.py", line 232, in main
status = self.run(options, args)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/commands/install.py", line 339, in run
requirement_set.prepare_files(finder)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/req/req_set.py", line 333, in prepare_files
upgrade=self.upgrade,
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 351, in find_requirement
for page in self._get_pages(locations, req):
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 566, in _get_pages
page = self._get_page(location, req)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 783, in _get_page
return HTMLPage.get_page(link, req, session=self.session)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 872, in get_page
"Cache-Control": "max-age=600",
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 473, in get
return self.request('GET', url, **kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/download.py", line 365, in request
return super(PipSession, self).request(method, url, *args, **kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 461, in request
resp = self.send(prep, **send_kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 599, in send
history = [resp for resp in gen] if allow_redirects else []
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 192, in resolve_redirects
allow_redirects=False,
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/cachecontrol/adapter.py", line 43, in send
resp = super(CacheControlAdapter, self).send(request, **kw)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/adapters.py", line 370, in send
timeout=timeout
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 518, in urlopen
body=body, headers=headers)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 322, in _make_request
self._validate_conn(conn)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 727, in _validate_conn
conn.connect()
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connection.py", line 238, in connect
ssl_version=resolved_ssl_version)
File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py", line 253, in ssl_wrap_socket
return context.wrap_socket(sock, server_hostname=server_hostname)
File "/usr/lib/python2.7/ssl.py", line 350, in wrap_socket
_context=self)
File "/usr/lib/python2.7/ssl.py", line 563, in __init__
self.close()
File "/usr/lib/python2.7/ssl.py", line 758, in close
if self._makefile_refs < 1:
AttributeError: 'SSLSocket' object has no attribute '_makefile_refs'
```
Diffs
-----
build-support/virtualenv 1cdfc7ff95fb4d2f748325610664f8912366bd2a
Diff: https://reviews.apache.org/r/33403/diff/
Testing (updated)
-------
End-to-end tests pass.
Thanks,
Bill Farner
Re: Review Request 33403: Upgrade to virtualenv 12.1.1
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33403/#review81028
-----------------------------------------------------------
Ship it!
LGTM if e2e tests pass
- Kevin Sweeney
On April 21, 2015, 11:14 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33403/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 11:14 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Upgrade to virtualenv 12.1.1
>
>
> Diffs
> -----
>
> build-support/virtualenv 1cdfc7ff95fb4d2f748325610664f8912366bd2a
>
> Diff: https://reviews.apache.org/r/33403/diff/
>
>
> Testing
> -------
>
> Encountered this stack trace after upgrading to ubuntu 14.10, upgrading virtualenv got me past it:
>
> ```
> $ ./rbt patch -c 33200
> Bootstrapping rbtools @ 0.7.0
> + VIRTUALENV_VERSION=12.0.7
> + which python2.7
> ++ which python2.7
> + PY=/usr/bin/python2.7
> + echo 'Using /usr/bin/python2.7'
> Using /usr/bin/python2.7
> +++ dirname /home/wfarner/code/aurora/build-support/virtualenv
> ++ cd /home/wfarner/code/aurora/build-support
> ++ pwd
> + HERE=/home/wfarner/code/aurora/build-support
> + '[' -f /home/wfarner/code/aurora/build-support/virtualenv-12.0.7/BOOTSTRAPPED ']'
> + exec /usr/bin/python2.7 /home/wfarner/code/aurora/build-support/virtualenv-12.0.7/virtualenv.py /home/wfarner/code/aurora/build-support/rbt.venv
> New python executable in /home/wfarner/code/aurora/build-support/rbt.venv/bin/python2.7
> Also creating executable in /home/wfarner/code/aurora/build-support/rbt.venv/bin/python
> Installing setuptools, pip...done.
> You are using pip version 6.0.8, however version 6.1.1 is available.
> You should consider upgrading via the 'pip install --upgrade pip' command.
> Collecting RBTools==0.7.0
> Exception:
> Traceback (most recent call last):
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/basecommand.py", line 232, in main
> status = self.run(options, args)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/commands/install.py", line 339, in run
> requirement_set.prepare_files(finder)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/req/req_set.py", line 333, in prepare_files
> upgrade=self.upgrade,
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 351, in find_requirement
> for page in self._get_pages(locations, req):
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 566, in _get_pages
> page = self._get_page(location, req)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 783, in _get_page
> return HTMLPage.get_page(link, req, session=self.session)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/index.py", line 872, in get_page
> "Cache-Control": "max-age=600",
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 473, in get
> return self.request('GET', url, **kwargs)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/download.py", line 365, in request
> return super(PipSession, self).request(method, url, *args, **kwargs)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 461, in request
> resp = self.send(prep, **send_kwargs)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 599, in send
> history = [resp for resp in gen] if allow_redirects else []
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 192, in resolve_redirects
> allow_redirects=False,
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/sessions.py", line 573, in send
> r = adapter.send(request, **kwargs)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/cachecontrol/adapter.py", line 43, in send
> resp = super(CacheControlAdapter, self).send(request, **kw)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/adapters.py", line 370, in send
> timeout=timeout
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 518, in urlopen
> body=body, headers=headers)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 322, in _make_request
> self._validate_conn(conn)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connectionpool.py", line 727, in _validate_conn
> conn.connect()
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/connection.py", line 238, in connect
> ssl_version=resolved_ssl_version)
> File "/home/wfarner/code/aurora/build-support/rbt.venv/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py", line 253, in ssl_wrap_socket
> return context.wrap_socket(sock, server_hostname=server_hostname)
> File "/usr/lib/python2.7/ssl.py", line 350, in wrap_socket
> _context=self)
> File "/usr/lib/python2.7/ssl.py", line 563, in __init__
> self.close()
> File "/usr/lib/python2.7/ssl.py", line 758, in close
> if self._makefile_refs < 1:
> AttributeError: 'SSLSocket' object has no attribute '_makefile_refs'
> ```
>
>
> Thanks,
>
> Bill Farner
>
>