You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by paulk-asert <gi...@git.apache.org> on 2016/04/09 13:51:44 UTC
[GitHub] groovy pull request: CliBuilder enhancements
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/308
CliBuilder enhancements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy cliSpike
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/groovy/pull/308.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #308
----
commit 56265169269b555a052dd8270781dec0da510d4a
Author: Paul King <pa...@asert.com.au>
Date: 2015-07-09T21:45:26Z
CliBuilder enhancements
commit e3909e3322a2d3741092b0bfba81987eabcb060f
Author: paulk <pa...@asert.com.au>
Date: 2016-04-06T12:31:35Z
add annotation support to CliBuilder
commit dbdcd20fbea6341f958df7a9169a6a3381452855
Author: paulk <pa...@asert.com.au>
Date: 2016-04-08T09:58:30Z
add documentation/tests for the convert option
commit e0490da27ae90402a97049b796ac1e9b2ee6a8f3
Author: paulk <pa...@asert.com.au>
Date: 2016-04-09T11:46:20Z
add documentation/tests for the defaultValue option
commit 419b18d82d6dd3448cfcaa090b49c4ff1bc0507c
Author: paulk <pa...@asert.com.au>
Date: 2016-04-09T11:49:29Z
remove unneeded tweak from build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request: CliBuilder enhancements
Posted by paulk-asert <gi...@git.apache.org>.
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/308#discussion_r59124276
--- Diff: src/main/groovy/cli/Unparsed.java ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package groovy.cli;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Indicates that a method will contain the remaining arguments.
--- End diff --
Nice suggestion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request: CliBuilder enhancements
Posted by shils <gi...@git.apache.org>.
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/308#discussion_r59120922
--- Diff: src/main/groovy/cli/Unparsed.java ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package groovy.cli;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * Indicates that a method will contain the remaining arguments.
--- End diff --
I think 'method or field' would be more appropriate here, given the usage within an annotation class spec e.g. GreeterC in CliBuilderTest.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request: CliBuilder enhancements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/308
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---