You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/24 04:20:06 UTC

[GitHub] [skywalking] tuohai666 opened a new pull request #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

tuohai666 opened a new pull request #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #3583
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114#issuecomment-568660704
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=h1) Report
   > Merging [#4114](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7c535f8612ec741144c90ec3deb9964642883dfa?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4114/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #4114      +/-   ##
   =========================================
   + Coverage   27.29%   27.3%   +<.01%     
   =========================================
     Files        1140    1140              
     Lines       25027   25027              
     Branches     3619    3619              
   =========================================
   + Hits         6831    6833       +2     
   + Misses      17590   17588       -2     
     Partials      606     606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4114/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `84.26% <0%> (+2.24%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=footer). Last update [7c535f8...9237c72](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114#issuecomment-568724002
 
 
   Why this include many unexpected commits from prev PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114#issuecomment-568660704
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=h1) Report
   > Merging [#4114](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d7f7799c8005845cf0d5e0ffe64133271f6846a4?src=pr&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4114/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #4114      +/-   ##
   =========================================
   + Coverage   27.29%   27.3%   +0.01%     
   =========================================
     Files        1140    1140              
     Lines       25027   25027              
     Branches     3619    3619              
   =========================================
   + Hits         6831    6834       +3     
   + Misses      17590   17588       -2     
   + Partials      606     605       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...walking/apm/agent/core/context/TracingContext.java](https://codecov.io/gh/apache/skywalking/pull/4114/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9UcmFjaW5nQ29udGV4dC5qYXZh) | `58.7% <0%> (+0.49%)` | :arrow_up: |
   | [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4114/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `84.26% <0%> (+2.24%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=footer). Last update [d7f7799...d3fa7b4](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] tuohai666 closed pull request #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

Posted by GitBox <gi...@apache.org>.
tuohai666 closed pull request #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114#issuecomment-568660704
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=h1) Report
   > Merging [#4114](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7c535f8612ec741144c90ec3deb9964642883dfa?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4114/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #4114      +/-   ##
   =========================================
   + Coverage   27.29%   27.3%   +<.01%     
   =========================================
     Files        1140    1140              
     Lines       25027   25027              
     Branches     3619    3619              
   =========================================
   + Hits         6831    6833       +2     
   + Misses      17590   17588       -2     
     Partials      606     606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4114/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `84.26% <0%> (+2.24%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=footer). Last update [7c535f8...9237c72](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114#issuecomment-568660704
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=h1) Report
   > Merging [#4114](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d7f7799c8005845cf0d5e0ffe64133271f6846a4?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4114/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4114      +/-   ##
   ==========================================
   - Coverage   27.29%   27.27%   -0.02%     
   ==========================================
     Files        1140     1140              
     Lines       25027    25027              
     Branches     3619     3619              
   ==========================================
   - Hits         6831     6826       -5     
   - Misses      17590    17595       +5     
     Partials      606      606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4114/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4114/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
   | [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/4114/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `84.26% <0%> (+2.24%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=footer). Last update [d7f7799...d3fa7b4](https://codecov.io/gh/apache/skywalking/pull/4114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] tuohai666 commented on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario

Posted by GitBox <gi...@apache.org>.
tuohai666 commented on issue #4114: [test/plugin] immigrate test shardingsphere 4.x RC1 RC2 scenario
URL: https://github.com/apache/skywalking/pull/4114#issuecomment-568732953
 
 
   It's because I didn't create a new branch. My master is different from upstream/master.
   The content of this pr is OK. Anyway, let me resolve this problem.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services