You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by et...@apache.org on 2008/10/18 22:33:29 UTC
svn commit: r705919 - in
/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets:
process/Processor.java render/HtmlRenderer.java
servlet/GadgetRenderingServlet.java
Author: etnu
Date: Sat Oct 18 13:33:29 2008
New Revision: 705919
URL: http://svn.apache.org/viewvc?rev=705919&view=rev
Log:
Improved error message propagation on rendering.
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/HtmlRenderer.java
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java?rev=705919&r1=705918&r2=705919&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java Sat Oct 18 13:33:29 2008
@@ -88,7 +88,7 @@
.setSpec(spec)
.setCurrentView(getView(context, spec));
} catch (GadgetException e) {
- throw new ProcessingException(e);
+ throw new ProcessingException(e.getMessage(), e);
}
}
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/HtmlRenderer.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/HtmlRenderer.java?rev=705919&r1=705918&r2=705919&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/HtmlRenderer.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/HtmlRenderer.java Sat Oct 18 13:33:29 2008
@@ -96,7 +96,7 @@
return rewriter.rewriteGadget(gadget, response.getResponseAsString());
}
} catch (GadgetException e) {
- throw new RenderingException(e);
+ throw new RenderingException(e.getMessage(), e);
}
}
}
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java?rev=705919&r1=705918&r2=705919&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetRenderingServlet.java Sat Oct 18 13:33:29 2008
@@ -69,7 +69,7 @@
resp.getWriter().print(results.getContent());
break;
case ERROR:
- resp.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR, results.getErrorMessage());
+ resp.sendError(HttpServletResponse.SC_BAD_GATEWAY, results.getErrorMessage());
break;
case MUST_REDIRECT:
resp.sendRedirect(results.getRedirect().toString());