You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by MLnick <gi...@git.apache.org> on 2016/05/06 06:56:35 UTC

[GitHub] spark pull request: [SPARK-15136][PySpark][DOC] Fix links to sphin...

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12918#discussion_r62294736
  
    --- Diff: python/pyspark/ml/classification.py ---
    @@ -454,7 +454,8 @@ class TreeClassifierParams(object):
         impurity = Param(Params._dummy(), "impurity",
                          "Criterion used for information gain calculation (case-insensitive). " +
                          "Supported options: " +
    -                     ", ".join(supportedImpurities), typeConverter=TypeConverters.toString)
    +                     ", ".join(supportedImpurities) + ". (Default: gini)",
    --- End diff --
    
    @holdenk could we leave this change out of this PR and keep it only for links? When we make a final call on approach for #12914 we can revisit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org