You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/04 14:17:31 UTC
[GitHub] [rocketmq-dashboard] StyleTang commented on a change in pull request #57: [ISSUE #55]Delete the corresponding DLQ and Retry Topic simultaneously when deleting the consumerGroup.
StyleTang commented on a change in pull request #57:
URL: https://github.com/apache/rocketmq-dashboard/pull/57#discussion_r778113789
##########
File path: src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
##########
@@ -303,6 +312,16 @@ public boolean deleteSubGroup(DeleteSubGroupRequest deleteSubGroupRequest) {
return true;
}
+ private void deleteResources(String topic, String brokerName, ClusterInfo clusterInfo) throws Exception {
+ mqAdminExt.deleteTopicInBroker(Sets.newHashSet(clusterInfo.getBrokerAddrTable().get(brokerName).selectBrokerAddr()), topic);
+ Set<String> nameServerSet = null;
+ if (StringUtils.isNotBlank(configure.getNamesrvAddr())) {
+ String[] ns = configure.getNamesrvAddr().split(";");
+ nameServerSet = new HashSet<>(Arrays.asList(ns));
+ }
+ mqAdminExt.deleteTopicInNameServer(nameServerSet, topic);
Review comment:
Just want to confirm whether there is a problem with the `deleteTopicInNameServer`
A SubGroup can exist in multiple brokers.
For example :
GROUP_1
|----- brokerA
|------brokerB
If we just want to delete GROUP_1 in brokerA, deleteTopicInNameServer will also be invoked. It will delete all the QueueData of this topic in namesvr, not sure whether it will cause issue or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org