You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/06 15:46:53 UTC

[GitHub] [pulsar] cbornet commented on a diff in pull request #16423: [fix][functions] Fix netty.DnsResolverUtil compat issue on JDK9+ for the function Runtimes

cbornet commented on code in PR #16423:
URL: https://github.com/apache/pulsar/pull/16423#discussion_r914998760


##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java:
##########
@@ -320,6 +320,11 @@ public static List<String> getCmd(InstanceConfig instanceConfig,
 
             args.add("-Dio.netty.tryReflectionSetAccessible=true");
 
+            // Needed for netty.DnsResolverUtil on JDK9+
+            if (!System.getProperty("java.version").startsWith("1.")) {

Review Comment:
   It will not start with `1.` I think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org