[GitHub] [incubator-mxnet] kedarbellare commented on a change in pull request #15121: [clojure] clojurify function names in image.clj namespace

[GitBox <gi...@apache.org>]

kedarbellare commented on a change in pull request #15121: [clojure] clojurify function names in image.clj namespace
URL: https://github.com/apache/incubator-mxnet/pull/15121#discussion_r289649162
 
 

 ##########
 File path: contrib/clojure-package/src/org/apache/clojure_mxnet/image.clj
 ##########
 @@ -60,14 +63,38 @@
   ([input-stream]
    (decode-image input-stream {})))
 
+(defn decode
+  "Decodes an image from an input stream with OpenCV.
+    `input-stream`: `InputStream` - Contains the binary encoded image
+    `color-flag`: 0 or 1 - Convert decoded image to grayscale (0) or color (1)
 
 Review comment:
   one thing i'm wondering is whether `color-flag` should be specified as `:grayscale` or `:color` and we handle the conversion to 0, 1 in this function?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services